From patchwork Fri Mar 17 22:42:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Sakoman X-Patchwork-Id: 21172 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24943C7618E for ; Fri, 17 Mar 2023 22:43:19 +0000 (UTC) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mx.groups.io with SMTP id smtpd.web11.490.1679092995562204261 for ; Fri, 17 Mar 2023 15:43:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@sakoman-com.20210112.gappssmtp.com header.s=20210112 header.b=zMYwDf84; spf=softfail (domain: sakoman.com, ip: 209.85.216.42, mailfrom: steve@sakoman.com) Received: by mail-pj1-f42.google.com with SMTP id fy10-20020a17090b020a00b0023b4bcf0727so6810318pjb.0 for ; Fri, 17 Mar 2023 15:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakoman-com.20210112.gappssmtp.com; s=20210112; t=1679092995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VDytXyTxdNBbPlibTP//Uz+TJUuWVxcTU9HByr7TLkw=; b=zMYwDf8440vW63ZIGiMVuJRIuCqOnUn+pMcmSD+M8Xfm09oKo2c0HnFX0BfLvBom1P 6w63S/jglx4nliMrN8wtsCwBpi2DTDTyri5ZRWZnp4ll/7p6c32DHDgXi6y2S/FvgBHi 4dfEg3CrZtfgCl6elNt13yAQvK0r1Hp0FqAiqHew8128gIMcpYv4Sn2+Pm7sA2D5Gv63 CEn7L5WpgghJWUTA1M8CWlq3xYDypKzxIns3X/GxFjufSVEyDKeRlGi3o4yFrYrB7Tc5 N1L7dWEqbIy8bPuUVdI85adNIaqUqTfZKdjNYhrBoUErAdI5gTjof0wwMiEKnbHprmQL ujcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679092995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VDytXyTxdNBbPlibTP//Uz+TJUuWVxcTU9HByr7TLkw=; b=pfAJHHmvLwyrk6wLaSRId+/6EE/qSCnJmMyB9tL8M2BBZO04+EQAaEVLPbV8730sR5 Ow19cC0ja5icEFo1t6W1k11/2qEM7g354bljwtp8e+HvmMd6+39EjGPaPgC9OIO0ZXMw 7JXGHwDrIMGQiD+YWBu767Qni7+qAZuxQksM6YAmonxhFUK7gDXe1d95GawSQlS0KxeV D1NpjxUVa/fws1KyS+a7CfW+O9V5wT3BZQvKlpk4WlagBmasMfKkbcBsYKvQUIpbhPxk 7wrbnAz0Wfy8KUPe2P0GS0eZpeHKuNkNVMMjocK20h3aF9RXnFAgx8bAVzLdzQiR6Ybi v2ng== X-Gm-Message-State: AO0yUKXyQ60j1vF2cLtWEgBFJg8PyAmN8u7ePGxLmXbGLM+VITfpTdk8 SXwbuDejngXAIsLddd31oph4vUZz/ghPIi6/k1c= X-Google-Smtp-Source: AK7set+Zzt0fo7cUn8R1/L30CWPoJM8r5bZrJB7dP8PJx/ZwGRx6ps0p8ehbT+xL4k5poENaWM/e+w== X-Received: by 2002:a17:903:2449:b0:19f:3cdc:56dc with SMTP id l9-20020a170903244900b0019f3cdc56dcmr10086833pls.33.1679092994683; Fri, 17 Mar 2023 15:43:14 -0700 (PDT) Received: from hexa.router0800d9.com (dhcp-72-253-4-112.hawaiiantel.net. [72.253.4.112]) by smtp.gmail.com with ESMTPSA id jb13-20020a170903258d00b001a19040435bsm2027152plb.100.2023.03.17.15.43.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 15:43:14 -0700 (PDT) From: Steve Sakoman To: openembedded-core@lists.openembedded.org Subject: [OE-core][kirkstone 18/21] toolchain-scripts: Handle spaces within user $PATH Date: Fri, 17 Mar 2023 12:42:32 -1000 Message-Id: <64dd672193b43b1364acc73918a54abaa93645e4.1679092796.git.steve@sakoman.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 17 Mar 2023 22:43:19 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178779 From: Kenfe-Mickael Laventure The environment-setup script generated by the recipe was not quoting the user existing PATH when updating it causing the export command to fail. Add necessary double quotes around $PATH. Signed-off-by: Kenfe-Mickael Laventure Signed-off-by: Alexandre Belloni (cherry picked from commit 42177ff2d45ee70ad00917bb6fbabca49dae4f59) Signed-off-by: Steve Sakoman --- meta/classes/toolchain-scripts.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass index d2562b5d38..d735d434e6 100644 --- a/meta/classes/toolchain-scripts.bbclass +++ b/meta/classes/toolchain-scripts.bbclass @@ -47,7 +47,7 @@ toolchain_create_sdk_env_script () { for i in ${CANADIANEXTRAOS}; do EXTRAPATH="$EXTRAPATH:$sdkpathnative$bindir/${TARGET_ARCH}${TARGET_VENDOR}-$i" done - echo "export PATH=$sdkpathnative$bindir:$sdkpathnative$sbindir:$sdkpathnative$base_bindir:$sdkpathnative$base_sbindir:$sdkpathnative$bindir/../${HOST_SYS}/bin:$sdkpathnative$bindir/${TARGET_SYS}"$EXTRAPATH':$PATH' >> $script + echo "export PATH=$sdkpathnative$bindir:$sdkpathnative$sbindir:$sdkpathnative$base_bindir:$sdkpathnative$base_sbindir:$sdkpathnative$bindir/../${HOST_SYS}/bin:$sdkpathnative$bindir/${TARGET_SYS}"$EXTRAPATH':"$PATH"' >> $script echo 'export PKG_CONFIG_SYSROOT_DIR=$SDKTARGETSYSROOT' >> $script echo 'export PKG_CONFIG_PATH=$SDKTARGETSYSROOT'"$libdir"'/pkgconfig:$SDKTARGETSYSROOT'"$prefix"'/share/pkgconfig' >> $script echo 'export CONFIG_SITE=${SDKPATH}/site-config-'"${multimach_target_sys}" >> $script