From patchwork Sat Nov 21 15:59:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Volk X-Patchwork-Id: 105138 Received: from mailout12.t-online.de (mailout12.t-online.de [194.25.134.22]) by mx.groups.io with SMTP id smtpd.msgproc02-g2.19018.1795276867222821018 for ; Sat, 21 Nov 2026 08:01:07 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=f_l_k@t-online.de header.s=20260216 header.b=hBWbKhJq; spf=pass (domain: t-online.de, ip: 194.25.134.22, mailfrom: f_l_k@t-online.de) Received: from fwd81.aul.t-online.de (fwd81.aul.t-online.de [10.223.144.107]) by mailout12.t-online.de (Postfix) with SMTP id 4A1C1E163 for ; Sat, 21 Nov 2026 17:01:02 +0100 (CET) Received: from localhost.localdomain ([84.154.170.58]) by fwd81.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1xUnWP-0tisTJ0; Sat, 21 Nov 2026 17:01:01 +0100 From: Markus Volk To: openembedded-core@lists.openembedded.org Subject: [oe-core][PATCH] cups: fix temporary queues for discovered printers Date: Sat, 21 Nov 2026 16:59:56 +0100 Message-ID: <20261121160050.1531479-2-f_l_k@t-online.de> X-Mailer: git-send-email 2.56.1 In-Reply-To: <20261121160050.1531479-1-f_l_k@t-online.de> References: <20261121160050.1531479-1-f_l_k@t-online.de> MIME-Version: 1.0 X-TOI-EXPURGATEID: 150726::1795276861-EEFFA818-4C8F6B92/0/0 CLEAN NORMAL X-TOI-MSGID: e0a0c6a2-b789-46ff-9339-b04389445036 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t-online.de; s=20260216; t=1795276862; i=f_l_k@t-online.de; bh=KmCGdX58y0yQFHX+EkWZVWJehsQphdF8NQ3EwqPDukU=; h=From:To:Subject:Date:In-Reply-To:References; b=hBWbKhJq5T8dBEGxwRUgJC/2ekT+dHhIF1Q5y9swBN85YwZk/+yf0vcvFq1J/nXlG agPGXVrUm1kJhsprViH1Uoj1hJkScp2X7NtI3lo156ZJeYQkogT+E3ENE74n3tPiZG AdtbQ8VeatfaPMF1VQJ6NOhsA+tT6nhlBd5R2gorZrm+/AMzPAJZXLPby+cKdZ5dwv 6nGs/6y8hrQysnNYSbWI6KB4bkgYMbCj8Mwe75IaQquwpEMeBg+eohzSRFL4BsibGt 2antHdnpI64C/Oeyb1soZaHuqo3tQrfzBbRLHBmEbrVgsla9BQ4sG4sQ1jJ/luhDlb 6Ao4Am73aAWDg== List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by lin-tor-korg-lkml-alma10-1 with HTTPS for ; Sat, 21 Nov 2026 16:01:08 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/250848 Since 2.4.20 cupsd stores the device URI "://" for every temporary queue: create_local_printer() reads the URI into device_uri_ptr but still splits and stores the former printer-name pointer. Discovered IPP Everywhere printers without a configured queue can no longer be used. Backport the two upstream fixes from the 2.4.x branch. Tested by printing to a discovered IPP Everywhere printer without a configured queue. AI-Generated: Uses Claude Code (Claude Opus 5.5) Signed-off-by: Markus Volk --- meta/recipes-extended/cups/cups.inc | 1 + ...Fix-regression-with-temporary-queues.patch | 42 +++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 meta/recipes-extended/cups/cups/0005-Fix-regression-with-temporary-queues.patch diff --git a/meta/recipes-extended/cups/cups.inc b/meta/recipes-extended/cups/cups.inc index f82fc0a1aa..b7579ff70a 100644 --- a/meta/recipes-extended/cups/cups.inc +++ b/meta/recipes-extended/cups/cups.inc @@ -13,6 +13,7 @@ SRC_URI = "${GITHUB_BASE_URI}/download/v${PV}/cups-${PV}-source.tar.gz \ file://0002-don-t-try-to-run-generated-binaries.patch \ file://libexecdir.patch \ file://0004-cups-fix-multilib-install-file-conflicts.patch \ + file://0005-Fix-regression-with-temporary-queues.patch \ file://volatiles.99_cups \ file://cups-volatiles.conf \ " diff --git a/meta/recipes-extended/cups/cups/0005-Fix-regression-with-temporary-queues.patch b/meta/recipes-extended/cups/cups/0005-Fix-regression-with-temporary-queues.patch new file mode 100644 index 0000000000..e72a9eecf4 --- /dev/null +++ b/meta/recipes-extended/cups/cups/0005-Fix-regression-with-temporary-queues.patch @@ -0,0 +1,42 @@ +From 67dcee9f60a2a1410993510ab00c7203af5c5804 Mon Sep 17 00:00:00 2001 +From: Michael R Sweet +Date: Fri, 9 Oct 2026 12:01:20 -0400 +Subject: [PATCH] Fix regression with temporary queues (Issue #1751) + +create_local_printer() took the device URI into device_uri_ptr, but still +split and stored the former printer-name pointer, so every temporary queue +got the device URI "://" and failed. + +Combines the upstream commits 67dcee9f60 and e11ff1a9e8 on the 2.4.x +branch, without the CHANGES.md entry. + +Upstream-Status: Backport [https://github.com/OpenPrinting/cups/commit/67dcee9f60a2a1410993510ab00c7203af5c5804, https://github.com/OpenPrinting/cups/commit/e11ff1a9e8c6ec71edbaac5d5e5590d11aff64ef] +--- +diff --git a/scheduler/ipp.c b/scheduler/ipp.c +index af8cf12..96364f4 100644 +--- a/scheduler/ipp.c ++++ b/scheduler/ipp.c +@@ -5796,11 +5796,11 @@ create_local_printer( + + if (nameptr) + { +- size_t host_len, +- server_name_len; ++ size_t host_len, /* Length of hostname */ ++ server_name_len; /* Length of server name */ + + /* Get host name of device URI */ +- httpSeparateURI(HTTP_URI_CODING_ALL, ptr, ++ httpSeparateURI(HTTP_URI_CODING_ALL, device_uri_ptr, + scheme, sizeof(scheme), userpass, sizeof(userpass), host, + sizeof(host), &port, resource, sizeof(resource)); + +@@ -5832,7 +5832,7 @@ create_local_printer( + cupsdSetDeviceURI(printer, uri); + } + else +- cupsdSetDeviceURI(printer, ptr); ++ cupsdSetDeviceURI(printer, device_uri_ptr); + + if (printer_geo_location) + cupsdSetString(&printer->geo_location, ippGetString(printer_geo_location, 0, NULL));