From patchwork Tue Jun 30 14:08:00 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 91412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5542FC43602 for ; Tue, 30 Jun 2026 14:08:13 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.21888.1782828488103326116 for ; Tue, 30 Jun 2026 07:08:08 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@arm.com header.s=foss header.b=m3/szwiI; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ross.burton@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 481DC2ED2 for ; Tue, 30 Jun 2026 07:08:03 -0700 (PDT) Received: from cesw-amp-gbt-1s-m12830-04.lab.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3BB383F85F for ; Tue, 30 Jun 2026 07:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782828487; bh=PgG308E44thjXAM6yVKIXqkj4Jeb2kqcFHjDE3rkf2k=; h=From:To:Subject:Date:In-Reply-To:References:From; b=m3/szwiIA6f9aZ/YTMU1OPSWTO2nVDHkk4JXVLdr78K3tFXbqiMRvyKbVT2dzaA0X sJLKxITsU9+fRDJwAj5WTNdMB5JmdvFSV2owRvMvLkFfRoTsI59nQ8y9OnWAQw1TiA pPYGi6QCdzMPzBE3iRj9qVoZvDPsc342HJV6vd/M= From: Ross Burton To: openembedded-core@lists.openembedded.org Subject: [PATCH 3/3] classes/insane: clean up do_qa_sysroot Date: Tue, 30 Jun 2026 15:08:00 +0100 Message-ID: <20260630140800.4018491-3-ross.burton@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260630140800.4018491-1-ross.burton@arm.com> References: <20260630140800.4018491-1-ross.burton@arm.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from 45-33-107-173.ip.linodeusercontent.com [45.33.107.173] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 30 Jun 2026 14:08:13 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/239901 do_populate_sysroot copies SYSROOT_DIRS into SYSROOT_DESTDIR, so there's no need to loop over SYSROOT_DIRS when checking files: qa_check_staged can just recurse down the entire tree. Signed-off-by: Ross Burton --- meta/classes-global/insane.bbclass | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 68ad78c39d6..9640738f49f 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -1222,9 +1222,7 @@ addtask do_package_qa_setscene python do_qa_sysroot() { bb.note("QA checking do_populate_sysroot") - sysroot_destdir = d.expand('${SYSROOT_DESTDIR}') - for sysroot_dir in d.expand('${SYSROOT_DIRS}').split(): - qa_check_staged(sysroot_destdir + sysroot_dir, d) + qa_check_staged(d.getVar("SYSROOT_DESTDIR"), d) oe.qa.exit_with_message_if_errors("do_populate_sysroot for this recipe installed files with QA issues", d) } do_populate_sysroot[postfuncs] += "do_qa_sysroot"