From patchwork Mon Sep 22 17:20:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 70702 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77067CAC592 for ; Mon, 22 Sep 2025 17:20:41 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.58375.1758561637272336389 for ; Mon, 22 Sep 2025 10:20:37 -0700 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ross.burton@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9EB591424 for ; Mon, 22 Sep 2025 10:20:28 -0700 (PDT) Received: from cesw-amp-gbt-1s-m12830-04.lab.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 75B1F3F5A1 for ; Mon, 22 Sep 2025 10:20:36 -0700 (PDT) From: Ross Burton To: openembedded-core@lists.openembedded.org Subject: [PATCH 3/3] lame: don't use -march=native when building with clang Date: Mon, 22 Sep 2025 18:20:24 +0100 Message-ID: <20250922172025.184116-3-ross.burton@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250922172025.184116-1-ross.burton@arm.com> References: <20250922172025.184116-1-ross.burton@arm.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 22 Sep 2025 17:20:41 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/223835 Because of a logic error, lame's configure always passes -march=native when building with clang. This is a terrible idea in general as it's not often your build machine and target hardware aligns, and leads to some amusing errors: unknown target CPU 'neoverse-n1' note: valid target CPU values are: i386, i486, ... Move the HAVE_CLANG block up into the FULL_OPTIMIZATION case, alongside HAVE_GCC. This option is never enabled (as it's basically "use native") so resolves the build failure. Signed-off-by: Ross Burton --- meta/recipes-multimedia/lame/lame/clang.patch | 99 +++++++++++++++++++ meta/recipes-multimedia/lame/lame_3.100.bb | 1 + 2 files changed, 100 insertions(+) create mode 100644 meta/recipes-multimedia/lame/lame/clang.patch diff --git a/meta/recipes-multimedia/lame/lame/clang.patch b/meta/recipes-multimedia/lame/lame/clang.patch new file mode 100644 index 00000000000..116000c577b --- /dev/null +++ b/meta/recipes-multimedia/lame/lame/clang.patch @@ -0,0 +1,99 @@ +Don't use -march=native when building with clang + +Because of a logic error, lame's configure always passes -march=native +when building with clang. + +This is a terrible idea in general as it's not often your build machine +and target hardware aligns, and leads to some amusing errors: + + unknown target CPU 'neoverse-n1' + note: valid target CPU values are: i386, i486, ... + +Move the HAVE_CLANG block up into the FULL_OPTIMIZATION case, alongside +HAVE_GCC. This option is never enabled (as it's basically "use native") +so resolves the build failure. + +Upstream-Status: Pending +Signed-off-by: Ross Burton + +diff --git i/configure.in w/configure.in +index 5e43179..d51b017 100644 +--- i/configure.in ++++ w/configure.in +@@ -960,45 +960,43 @@ if test "x$HAVE_GCC" = "xyes" -o "x$HAVE_CLANG" = "xyes"; then + ;; + esac + fi ++ ++ if test "x${HAVE_CLANG}" = "xyes"; then ++ case "${CLANG_VERSION}" in ++ 3.[89]*|[45].*) ++ OPTIMIZATION="-Ofast" ++ ;; ++ *) ++ OPTIMIZATION="-O3" ++ ;; ++ esac ++ ++ # generic CPU specific options ++ case ${host_cpu} in ++ *486) ++ OPTIMIZATION="${OPTIMIZATION} -march=i486" ++ ;; ++ *586) ++ OPTIMIZATION="${OPTIMIZATION} -march=i586 \ ++ -mtune=native" ++ ;; ++ *686) ++ OPTIMIZATION="${OPTIMIZATION} -march=i686 \ ++ -mtune=native" ++ ;; ++ *86) ++ OPTIMIZATION="${OPTIMIZATION} -march=native \ ++ -mtune=native" ++ ;; ++ esac ++ ++ fi + ;; + *) + AC_MSG_ERROR(bad value �${CONFIG_EXPOPT}� for expopt option) + ;; + esac + +- +- if test "x${HAVE_CLANG}" = "xyes"; then +- case "${CLANG_VERSION}" in +- 3.[89]*|[45].*) +- OPTIMIZATION="-Ofast" +- ;; +- *) +- OPTIMIZATION="-O3" +- ;; +- esac +- +- # generic CPU specific options +- case ${host_cpu} in +- *486) +- OPTIMIZATION="${OPTIMIZATION} -march=i486" +- ;; +- *586) +- OPTIMIZATION="${OPTIMIZATION} -march=i586 \ +- -mtune=native" +- ;; +- *686) +- OPTIMIZATION="${OPTIMIZATION} -march=i686 \ +- -mtune=native" +- ;; +- *86) +- OPTIMIZATION="${OPTIMIZATION} -march=native \ +- -mtune=native" +- ;; +- esac +- +- fi +- +- + if test "${expopt_msg_result_printed}" = "no" ; then + AC_MSG_RESULT(${CONFIG_EXPOPT}) + fi diff --git a/meta/recipes-multimedia/lame/lame_3.100.bb b/meta/recipes-multimedia/lame/lame_3.100.bb index efaf3b9817a..42689df3511 100644 --- a/meta/recipes-multimedia/lame/lame_3.100.bb +++ b/meta/recipes-multimedia/lame/lame_3.100.bb @@ -12,6 +12,7 @@ DEPENDS = "ncurses gettext-native" SRC_URI = "${SOURCEFORGE_MIRROR}/lame/lame-${PV}.tar.gz \ file://no-gtk1.patch \ + file://clang.patch \ " SRC_URI[sha256sum] = "ddfe36cab873794038ae2c1210557ad34857a4b6bdc515785d1da9e175b1da1e"