From patchwork Sun Aug 17 20:18:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Kjellerstedt X-Patchwork-Id: 68688 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE99CA0EDC for ; Sun, 17 Aug 2025 20:18:52 +0000 (UTC) Received: from DU2PR03CU002.outbound.protection.outlook.com (DU2PR03CU002.outbound.protection.outlook.com [52.101.65.14]) by mx.groups.io with SMTP id smtpd.web10.60206.1755461922651993381 for ; Sun, 17 Aug 2025 13:18:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@axis.com header.s=selector1 header.b=B8M4r4NU; spf=pass (domain: axis.com, ip: 52.101.65.14, mailfrom: peter.kjellerstedt@axis.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ola1ONv7N2xUOAvgpcaBS3zvArPZeyFVSShylbbPuG45pBEgYoAChf0GtyvUjEy3qFg8fANMmFzGBaSjsauY3c3KhZY0mvqpvJcWZJAsoEf9FTWAdBoUrLq0O1GiXdeYhgbgXK5g4FfJ/W0VtF3spHxqW3C6Ve90uBKbSSHFgiFlnFYa6MKmDNfgtFoy95gxCBd+mmfuxZ+fJJXmtylnBd5ycC3uttyHkvSH5SPfPDPj6zi6CZXBmAoCccIHIKYlG4aQohaRssgXSa5O0e1opI01BKKfZpBUZvn5O9Inr+sXPoJWjHKjKBaBqcCIArcLk7tWsL76YPG4t0RSHu3ZIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mo3Iq7/FYayRzgRfVE1Q+CVdKhFo1PKw1P9lDlvq3Dc=; b=c0CgXsFDXs99+cVewN0JIxGhOd4jXuuUZgZZTLXmbcL7t4Xm94tRfLtjCi0D0XI8At9qY2xKU8bQiPgWrxTpSeyX/LTLLSel5SReu14UiA24W7WZh3c2zB2nqTEaz2B3e2OaomyKY5bgjJ96q06SXFgfUWLfZoZmq06W3ZFYH+9WGh9uIjaR1PW8nseMUFRNjB+Agj1tADi2FxtrX0QS5XEFN17a7KJuVH5fXMaOgj4W32r/Y1MenbKD5L8+7L1ctZBI6DRM71Uz2VQSnzZ3jDVh5khQWsDeauBgos4goSWekPjj7HLXpOZVqtA8oMFHh7Y9fStqlYYxDgKg9+QHrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 195.60.68.100) smtp.rcpttodomain=lists.openembedded.org smtp.mailfrom=axis.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mo3Iq7/FYayRzgRfVE1Q+CVdKhFo1PKw1P9lDlvq3Dc=; b=B8M4r4NUOdsv3flrjusNCZqPIsACUn+OGqGFgrEC4wAmVdlWj+jvcUeTXS3tS4kTJnGRFjim/i22h6Fn5K6Q76rwmhNPvYbB4Fgw7f3rEZVLJmVPQS7yRio/ZeAYt1Kprka1D2j1Zhd1T7zZLY0PSSFbZIFH1KvjwRMbWPXyqpw= Received: from DBBPR09CA0036.eurprd09.prod.outlook.com (2603:10a6:10:d4::24) by GV2PR02MB11201.eurprd02.prod.outlook.com (2603:10a6:150:2ae::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.15; Sun, 17 Aug 2025 20:18:35 +0000 Received: from DB5PEPF00014B98.eurprd02.prod.outlook.com (2603:10a6:10:d4:cafe::ed) by DBBPR09CA0036.outlook.office365.com (2603:10a6:10:d4::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9031.19 via Frontend Transport; Sun, 17 Aug 2025 20:18:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=axis.com; Received-SPF: Pass (protection.outlook.com: domain of axis.com designates 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; pr=C Received: from mail.axis.com (195.60.68.100) by DB5PEPF00014B98.mail.protection.outlook.com (10.167.8.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9052.8 via Frontend Transport; Sun, 17 Aug 2025 20:18:35 +0000 Received: from se-mail02w.axis.com (10.20.40.8) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Sun, 17 Aug 2025 22:18:34 +0200 Received: from se-intmail02x.se.axis.com (10.4.0.28) by se-mail02w.axis.com (10.20.40.8) with Microsoft SMTP Server id 15.1.2507.44 via Frontend Transport; Sun, 17 Aug 2025 22:18:34 +0200 Received: from pc56063-2339.se.axis.com (pc56063-2339.se.axis.com [10.92.3.2]) by se-intmail02x.se.axis.com (Postfix) with ESMTP id CAD20235D for ; Sun, 17 Aug 2025 22:18:34 +0200 (CEST) Received: by pc56063-2339.se.axis.com (Postfix, from userid 14323) id BC19C1203B4; Sun, 17 Aug 2025 22:18:34 +0200 (CEST) From: Peter Kjellerstedt To: Subject: [PATCHv4 1/2] systemd-systemctl-native: Install systemd-sysv-install Date: Sun, 17 Aug 2025 22:18:31 +0200 Message-ID: <20250817201832.2462509-1-pkj@axis.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PEPF00014B98:EE_|GV2PR02MB11201:EE_ X-MS-Office365-Filtering-Correlation-Id: 4bc9312b-1b92-40c4-5316-08ddddcb3e70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700013|13003099007; X-Microsoft-Antispam-Message-Info: Zj6CG1cmtczuLROKJtXzJJTH+G1QxVb5m0NG+G8dkr1sVmcLsPATWVi9ddJZWmbvPY5SKWw6w7/U1FHy1oC5nQS/yqJP6suF/1/JN7sbj0NVsN4w8WVdy8kPHE/o8y4/qgcy7wicZaCUH9yJUvvISRTm+csdHFY3LawTqn8x5ZAEuf7HaVyhs74ETq89MbVWOYt/rxzbCDstnven0qser8z6futXNbIu7i/+YhnDTgljrYSaAo68bem3OWkTP6Fj2VDnqgRX7kPihvpPy+zh0pIw55jZ5Tj7YXPxMe77DncYP6fXLX4dKRkfhMPRFvslrKlViyfOJKXBy78tjjN6qjDBqi2FKDWYrbwU/csIrzglDY5S5Ense6MybL/MUzKRabRs4h4nu/NgAcFl/Vf2ENqPXHzfzRPOPkXpAeu3FTMtfOOAxJdMkvw0Wknlw32I/W74YnkMQ0QG0oHPexhDvBw/9HMrW4Fp7sRdYZRfiy5fz2GKdjFlz22GYLmmmgCYoR8bodVfEsV3P7CwRO7ju7msCJEa1f2+7g74zyvsvJD8phUTRvFwhEvMwb33NM885N0wqa3m1IQPlKdr6soMHulsYrQe+gyaMRLuzTVbxzsYUApwuaz7Y794cm0YwArV1dhhwPUvmN95H1JyjEgx1M9CFX2c4ZzSlrwswHU4P79HebI4xOAyl4BWdjIElDtLKw8g+jkPmhwr9aP+/l9jYN2X2b2N+zb/QhrZ5QsHAxh1rN/3SpaGMb2GzP3iN4UEPIJeFN57OVPjWaI02bju4/fU0Nvx0sW7YfC6E2q+R/5qPpnLmZIYY7V+AwcBT8JGqwfJBuzmjniMaRQpBIiDWpfsGJ52w5PRJOamAgXSFA/KgJ/YmCghEK0ybTsAjPt4C8tyMpTXpL2/yNl/GAOUrku8ObB13LuNUs6q2hhsPmBKdspSy5QWrucl+xSAl/8vJzPw2zsxM+/WCg9/TIk3VTCDL4ydd2Ylg1JQEsHsX2jppavFs9HJkrC/2335oRfWXxo0RvjlZf1Nu3qfUarNumMk5kuA4KagQatomXZiMid0wtWsqV1pBUBG81v4E2weQ1YzY1H+ZyAgM4JwuvD2dsBE9KED8Za6Xif33UL6B/7ZmdgxbclzhZBvHQPMf7bEUM0/Q2anRrMehzEYY7VB8nRW+SmdxMjcrVajp2JhTWZCm5b7B+5sWItSEFfjB5KopFjAaXlJg2B7/VWZokerRWudgGy4OvvIAZfgjnvT41Eyqkg2wj9HSGccadTOa0ZEJFoHTM0JKPhCRSGwJ5f8eHLe0b3pJneGr8EZqrkZUGhCUbaV7brTgXfwjGArgBU1GJej98t2LPiJZ7oS/D5/a7xVu+WWYrYO78bit8TeHZ5B3Gd+upJB8Rm74Zt967Jhp8oi0V4J3Ete9s7pLO62/NZbjRRaTYeNVKCHluBvcQZ6bvkqOAoOOF7tmI3G+XA5jm4DsqNLRNGZCsS3tdYraw== X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2025 20:18:35.1633 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4bc9312b-1b92-40c4-5316-08ddddcb3e70 X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B98.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR02MB11201 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 17 Aug 2025 20:18:52 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/222016 It is needed when support for both systemd and sysvinit are enabled. This also adds a patch for systemctl to allow the path to systemd-sysv-install to be specified in runtime. This is needed because the hardcoded path that is built into systemctl does not match the path to where it will eventually be executed. Signed-off-by: Peter Kjellerstedt --- PATCHv2: New. PATCHv3: Change the Upstream-Status to Denied. PATCHv4: Add a Signed-off-by to the new patch. .../systemd/systemd-systemctl-native_257.8.bb | 16 ++ ...sv-install-to-specify-path-to-system.patch | 145 ++++++++++++++++++ ...implment-systemd-sysv-install-for-OE.patch | 13 +- 3 files changed, 165 insertions(+), 8 deletions(-) create mode 100644 meta/recipes-core/systemd/systemd/0001-systemctl-Add-sysv-install-to-specify-path-to-system.patch diff --git a/meta/recipes-core/systemd/systemd-systemctl-native_257.8.bb b/meta/recipes-core/systemd/systemd-systemctl-native_257.8.bb index 041a040a26..6030ab7acf 100644 --- a/meta/recipes-core/systemd/systemd-systemctl-native_257.8.bb +++ b/meta/recipes-core/systemd/systemd-systemctl-native_257.8.bb @@ -1,9 +1,14 @@ +FILESEXTRAPATHS:prepend := "${THISDIR}/systemd:" + SUMMARY = "Systemctl executable from systemd" require systemd.inc DEPENDS = "gperf-native libcap-native util-linux-native python3-jinja2-native" +SRC_URI += "file://0001-systemctl-Add-sysv-install-to-specify-path-to-system.patch" +SRC_URI += "file://0002-implment-systemd-sysv-install-for-OE.patch" + inherit pkgconfig meson native MESON_TARGET = "systemctl:executable" @@ -14,3 +19,14 @@ EXTRA_OEMESON += "-Dlink-systemctl-shared=false" # determined at run-time, but rather set during configure # More details are here https://github.com/systemd/systemd/issues/35897#issuecomment-2665405887 EXTRA_OEMESON += "--sysconfdir ${sysconfdir_native}" + +do_install:append() { + if ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', 'true', 'false', d)}; then + # Use ${libdir}/systemd rather than ${systemd_unitdir} here + # because the latter is affected by whether the usrmerge distro + # feature is set _for native_ (which it typically isn't), and we + # need to know the path to systemd-sysv-install in the + # systemd.bbclass when building _for target_. + install -Dm 0755 ${S}/src/systemctl/systemd-sysv-install.SKELETON ${D}${libdir}/systemd/systemd-sysv-install + fi +} diff --git a/meta/recipes-core/systemd/systemd/0001-systemctl-Add-sysv-install-to-specify-path-to-system.patch b/meta/recipes-core/systemd/systemd/0001-systemctl-Add-sysv-install-to-specify-path-to-system.patch new file mode 100644 index 0000000000..fb79ceecc6 --- /dev/null +++ b/meta/recipes-core/systemd/systemd/0001-systemctl-Add-sysv-install-to-specify-path-to-system.patch @@ -0,0 +1,145 @@ +From eb02a1bf3bfcc73302c7849cedfa756799168c5d Mon Sep 17 00:00:00 2001 +From: Peter Kjellerstedt +Date: Thu, 14 Aug 2025 22:48:00 +0200 +Subject: [PATCH] systemctl: Add --sysv-install to specify the path to + systemd-sysv-install + +This allows the path to systemd-sysv-install to be specified in runtime. + +The hardcoded path to systemd-sysv-install in systemctl causes problems +when they need to be run from some other location than the expected, +e.g., when used in a sysroot. + +Upstream-Status: Denied [https://github.com/systemd/systemd/pull/38614] +Signed-off-by: Peter Kjellerstedt +--- + man/systemctl.xml | 13 +++++++++++++ + src/systemctl/systemctl-sysv-compat.c | 6 +++++- + src/systemctl/systemctl.c | 11 +++++++++++ + src/systemctl/systemctl.h | 1 + + 4 files changed, 30 insertions(+), 1 deletion(-) + +diff --git a/man/systemctl.xml b/man/systemctl.xml +index be9fa4803c..ad1bbaf1a1 100644 +--- a/man/systemctl.xml ++++ b/man/systemctl.xml +@@ -2885,6 +2885,19 @@ EOF + + + ++ ++ ++ ++ ++ When used with ++ enable/disable/is-enabled ++ on a unit that is a SysV init.d script, use the specified path instead of ++ /usr/lib/systemd/systemd-sysv-install to call the ++ distribution's mechanism for enabling/disabling it. ++ ++ ++ ++ + + + +diff --git a/src/systemctl/systemctl-sysv-compat.c b/src/systemctl/systemctl-sysv-compat.c +index cb9c43e3dc..96b3c451f0 100644 +--- a/src/systemctl/systemctl-sysv-compat.c ++++ b/src/systemctl/systemctl-sysv-compat.c +@@ -3,6 +3,7 @@ + #include + #include + #include ++#include + + #include "env-util.h" + #include "fd-util.h" +@@ -132,6 +133,9 @@ int enable_sysv_units(const char *verb, char **args) { + "is-enabled")) + return 0; + ++ if (arg_sysv_install && access(arg_sysv_install, X_OK) < 0) ++ return log_error_errno(errno, "%s is not executable: %m", arg_sysv_install); ++ + r = lookup_paths_init_or_warn(&paths, arg_runtime_scope, LOOKUP_PATHS_EXCLUDE_GENERATED, arg_root); + if (r < 0) + return r; +@@ -140,7 +144,7 @@ int enable_sysv_units(const char *verb, char **args) { + while (args[f]) { + + const char *argv[] = { +- LIBEXECDIR "/systemd-sysv-install", ++ arg_sysv_install ?: LIBEXECDIR "/systemd-sysv-install", + NULL, /* --root= */ + NULL, /* verb */ + NULL, /* service */ +diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c +index 8c9fcb69f2..1e718e7d87 100644 +--- a/src/systemctl/systemctl.c ++++ b/src/systemctl/systemctl.c +@@ -126,6 +126,7 @@ bool arg_mkdir = false; + bool arg_marked = false; + const char *arg_drop_in = NULL; + ImagePolicy *arg_image_policy = NULL; ++char *arg_sysv_install = NULL; + + STATIC_DESTRUCTOR_REGISTER(arg_types, strv_freep); + STATIC_DESTRUCTOR_REGISTER(arg_states, strv_freep); +@@ -141,6 +142,7 @@ STATIC_DESTRUCTOR_REGISTER(arg_boot_loader_entry, unsetp); + STATIC_DESTRUCTOR_REGISTER(arg_clean_what, strv_freep); + STATIC_DESTRUCTOR_REGISTER(arg_drop_in, unsetp); + STATIC_DESTRUCTOR_REGISTER(arg_image_policy, image_policy_freep); ++STATIC_DESTRUCTOR_REGISTER(arg_sysv_install, freep); + + static int systemctl_help(void) { + _cleanup_free_ char *link = NULL; +@@ -348,6 +350,7 @@ static int systemctl_help(void) { + " --when=TIME Schedule halt/power-off/reboot/kexec action after\n" + " a certain timestamp\n" + " --stdin Read new contents of edited file from stdin\n" ++ " --sysv-install=PATH The path to systemd-sysv-install\n" + "\nSee the %2$s for details.\n", + program_invocation_short_name, + link, +@@ -475,6 +478,7 @@ static int systemctl_parse_argv(int argc, char *argv[]) { + ARG_DROP_IN, + ARG_WHEN, + ARG_STDIN, ++ ARG_SYSV_INSTALL, + }; + + static const struct option options[] = { +@@ -543,6 +547,7 @@ static int systemctl_parse_argv(int argc, char *argv[]) { + { "drop-in", required_argument, NULL, ARG_DROP_IN }, + { "when", required_argument, NULL, ARG_WHEN }, + { "stdin", no_argument, NULL, ARG_STDIN }, ++ { "sysv-install", required_argument, NULL, ARG_SYSV_INSTALL }, + {} + }; + +@@ -1052,6 +1057,12 @@ static int systemctl_parse_argv(int argc, char *argv[]) { + arg_stdin = true; + break; + ++ case ARG_SYSV_INSTALL: ++ r = parse_path_argument(optarg, false, &arg_sysv_install); ++ if (r < 0) ++ return r; ++ break; ++ + case '.': + /* Output an error mimicking getopt, and print a hint afterwards */ + log_error("%s: invalid option -- '.'", program_invocation_name); +diff --git a/src/systemctl/systemctl.h b/src/systemctl/systemctl.h +index 00405f4705..1db16d0183 100644 +--- a/src/systemctl/systemctl.h ++++ b/src/systemctl/systemctl.h +@@ -105,6 +105,7 @@ extern bool arg_mkdir; + extern bool arg_marked; + extern const char *arg_drop_in; + extern ImagePolicy *arg_image_policy; ++extern char *arg_sysv_install; + + static inline const char* arg_job_mode(void) { + return _arg_job_mode ?: "replace"; diff --git a/meta/recipes-core/systemd/systemd/0002-implment-systemd-sysv-install-for-OE.patch b/meta/recipes-core/systemd/systemd/0002-implment-systemd-sysv-install-for-OE.patch index d8bb572261..20a2f01317 100644 --- a/meta/recipes-core/systemd/systemd/0002-implment-systemd-sysv-install-for-OE.patch +++ b/meta/recipes-core/systemd/systemd/0002-implment-systemd-sysv-install-for-OE.patch @@ -1,7 +1,7 @@ -From fab8c573d06340868f070446118673b1c23584c5 Mon Sep 17 00:00:00 2001 +From b9fb0368fa54655eccb086b4152f3a2824d2ad53 Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Sat, 5 Sep 2015 06:31:47 +0000 -Subject: [PATCH 02/26] implment systemd-sysv-install for OE +Subject: [PATCH] implement systemd-sysv-install for OE Use update-rc.d for enabling/disabling and status command to check the status of the sysv service @@ -14,7 +14,7 @@ Signed-off-by: Khem Raj 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/systemctl/systemd-sysv-install.SKELETON b/src/systemctl/systemd-sysv-install.SKELETON -index cb58d8243b..000bdf6165 100755 +index cb58d8243b..eff3f5f579 100755 --- a/src/systemctl/systemd-sysv-install.SKELETON +++ b/src/systemctl/systemd-sysv-install.SKELETON @@ -34,17 +34,17 @@ case "$1" in @@ -22,13 +22,13 @@ index cb58d8243b..000bdf6165 100755 # call the command to enable SysV init script $NAME here # (consider optional $ROOT) - echo "IMPLEMENT ME: enabling SysV init.d script $NAME" -+ update-rc.d -f $NAME defaults ++ update-rc.d ${ROOT:+-r $ROOT} -f $NAME defaults ;; disable) # call the command to disable SysV init script $NAME here # (consider optional $ROOT) - echo "IMPLEMENT ME: disabling SysV init.d script $NAME" -+ update-rc.d -f $NAME remove ++ update-rc.d ${ROOT:+-r $ROOT} -f $NAME remove ;; is-enabled) # exit with 0 if $NAME is enabled, non-zero if it is disabled @@ -38,6 +38,3 @@ index cb58d8243b..000bdf6165 100755 ;; *) usage ;; --- -2.34.1 -