From patchwork Tue Jan 21 08:12:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jan_Strater-B=C3=BCddefeld?= X-Patchwork-Id: 55883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E08C02182 for ; Tue, 21 Jan 2025 08:13:01 +0000 (UTC) Received: from FR4P281CU032.outbound.protection.outlook.com (FR4P281CU032.outbound.protection.outlook.com [40.107.149.127]) by mx.groups.io with SMTP id smtpd.web11.11482.1737447180504907106 for ; Tue, 21 Jan 2025 00:13:00 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@mbs-solutions.de header.s=selector1 header.b=nrL6NESU; spf=pass (domain: mbs-solutions.de, ip: 40.107.149.127, mailfrom: jst@mbs-solutions.de) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IWyX6w1jGvlxQFnuCk0wAYGTJeLWFRrkSCyLryVF8dVyLkAMGzJzuJtKt0L/mV6ud4xDavW4yGreDJiVHnVMiBPj61XGNJ8u2lDgVX9pdVZhJQNTsgyiPt4oXoh8VRfxyMo1TwKXuM1Id/ePEH+w2a8RskPEGT3zlfpGG/7BmgZ6r3YYcHzN0RErJfFtIsj7htCM4nCaIE0G5ikoK8l62SH7WMNg/j9fxEEu7u09N7OuN22kElvPD94troZ4F/NRUUaFIz/xg8m1+lW6FF7DdoGqHnkYm6VJTaZrq8t3irQShOyuvwvPZoydwtYVYBpt5rqtWVJWobWhNsTRi95xnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ui54789n29SbIPN7Pz+v7JarX0vliD9+EcPfzhNk3HY=; b=ZpKFw/pN5obyX8Sy6MTKaU446s7xw+SqAg39P4iEi4yXhOKCeNrt7ecrqK2wdXw9ulog1CWRMrFwV/e608C2tqi4wqznzt2ks99s7zA+nEYhrx7TiMq2wLhq+iD1BWasvNI0F9V6RJuTqOySpj62ylYP6MZj+Gv2MjwdjWXcU3sB4lVCvny40ff7G7g2GQo6dxaPTUSiqgUby72Cb4h9ucQ3CaN1iUTjR8vCaZyMBtid9+PQRD8hXMvta9HylDxExYxHf7/vdDa/d6Ln4ixKF4gs1Vv8638odF7voBJaydZP1YDIl7bXWiWJljXOlBtM/NyF10EYzX1b4Zfw4P43jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mbs-solutions.de; dmarc=pass action=none header.from=mbs-solutions.de; dkim=pass header.d=mbs-solutions.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbs-solutions.de; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ui54789n29SbIPN7Pz+v7JarX0vliD9+EcPfzhNk3HY=; b=nrL6NESUhnP/S8MMvnDkKlTeHMlNuuQyIh6EZBlhsIF/Bi8jJAopj2e4s1v87lrPn/zg6Xwg3RSzPZENaQjbTbGR3CmGI8LCUAHprN4b/FXw4blcVdchd7js3H1X+UcZRVbr3RkLLsxA1FY3ny9pYoM6yUjLDe6fb+XSy6rh/rU4ZyMIlrOFW9xAA4a9sc/s2O06AXbHFTeg4TXyt2mBb9Jemj9ZH1FSy4VJUgOXloHQGyqJRvpCatbF6VdbpKnSU1EGdbaez3MJLvkRNgl4dhEDJR3/L8TpL2uvgptJ3LDAi1rUJEJYOXma7+MvJn+y/wB6bJwnUO/J70HCAWdYiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mbs-solutions.de; Received: from FRYP281MB2522.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:71::11) by BEYP281MB4519.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:ac::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.23; Tue, 21 Jan 2025 08:12:56 +0000 Received: from FRYP281MB2522.DEUP281.PROD.OUTLOOK.COM ([fe80::8a76:8812:5cd2:3e5c]) by FRYP281MB2522.DEUP281.PROD.OUTLOOK.COM ([fe80::8a76:8812:5cd2:3e5c%4]) with mapi id 15.20.8356.020; Tue, 21 Jan 2025 08:12:56 +0000 From: =?utf-8?q?Jan_Strater-B=C3=BCddefeld?= To: openembedded-core@lists.openembedded.org CC: =?utf-8?q?Jan_Strater-B=C3=BCddefeld?= Subject: [PATCH] cargo: remove LD_LIBRARY_PATH wrapper Date: Tue, 21 Jan 2025 09:12:20 +0100 Message-ID: <20250121081220.35589-1-jst@mbs-solutions.de> X-Mailer: git-send-email 2.45.2 X-ClientProxiedBy: BE1P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:7b::16) To FRYP281MB2522.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:71::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: FRYP281MB2522:EE_|BEYP281MB4519:EE_ X-MS-Office365-Filtering-Correlation-Id: c004be65-1033-4042-43e1-08dd39f36979 X-ETR: Bypass spam filtering for authenticated sender 'mbs-solutions.de' X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|1800799024|366016|376014|38350700014; X-Microsoft-Antispam-Message-Info: cjAPb0H/uaZXsaZt4DjWVfbneV5Z5nDyTnjt+ihQjZdhljcj/1WMLTVsN8mdaRrxoQtPnKyzJmIoTDsbA1GMJXjmwt42zoiVqiWEaOi9O6nxW/6/ufpPf7sUyOOLOp80Cmzo/nX/f0X0BlkosBtzrYAj1FWj4kMiuWdYlzUpGm7W3GRxVqLkmcjto5nVvLaaspMt0agM13Jhi8ITbH5ZSPygsQm3R3OiI2VrFU1m28MORhBx/t38puaffObNgmm5LGW5mLHFVXWcfnBBJcW2qkjoqIp3jEQevOXaZ6QtQTRzfDmulC2i2Gy3j7b0toFYygG5wWfe1KXe+Ya32a4gXZsVHvWJ4l86kWYIimbX3YAcdbwBiZxcMP99yooCFhH8U+98xoaPrQtj68vyZGHWYeRsh6BktIAtYWM87cPMY9uOO3sO/GjBUYU6sAOtBhrLGva5I1yhHAgnzMGkSNLkxGt6QFGLuSJzGXSbhl+8U46a25OZL8Ed8+AOeN8Tpq/jw5fKFDK61GhJnP8+aFvv+6OqEPBRUsFC8ek/cnYPj5VCNiD3uLsmf7/WOpcVsWDmqJ+KIvI8mIRXVSNhogwnzEBGJovs/f/lUQKYJ50gJU3Zv9Rm6+uIHB8SmOWaGU6UMbcpr9+J9aWs/N1LpgjzUcDDKgDcxJ8aRh+icd+RIcrLVk4oacezQI6D0zdGaUV19bnJ4q2pW1UpPKvZu3pdmhS16HT+zzSoYch5OF4Zdn1xRrDrfbEf6qZw8UWtKzTFgd40nyZwIW5wCnQB2eqBhccnFzOyfkWgvx+mzt0qQZfb/Dgevr83g+IWMEXM58aA70G4c4lWi03GSyzqdyVMT8isv7+v/KjaoipPeFHG9FbW3TWXKwsm6VF5lTGvEFbI8CP9mnAmBmbpyantXqq+ezgmiUgThcdlDUJW8ehU+hwczErP9FOKBsq+HiLFmqpRG8pnVOaqOzESDDk+AJAbkQB3yx9BkThUh4bE7O0Bgfb8j5wJMl7OumqYGrz6kOB9q7Hf7Ly6jXqcSRYdFXk/yWO+qYE23LFekEP9ygHj599ucmQC1oVl80M/URzlve8mL7M9amu1qp6CCX6Aou/xVYy5jiNY1h0DDXqgU7ymTD1mXWvx7Q+XqsfkD7o2wySNa2ZqIxu6T7WX8M5K0lrzoR3I97y46THgEQpiPfgfksDbMzSBP3CDpmIgpjM0kD5IOR9h3pno57mcBMw/iWU3Ve4UkKCQrZl26II4icKGP7CmuquNwbNut6B81E+MZaExf6KbiU8UtmwkJ2TrP9cfVJmxNgnplj1pSCEH9/VyhXUGoJJGbJVedh3I0XecYluXARrsY6D5ouj/w6J0VwAK1y+kjWliwanvyz7tJy90L2vS4nLWotd04eHp7jOAERbZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:FRYP281MB2522.DEUP281.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(52116014)(1800799024)(366016)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iWTbTgB2AAs4EkVSAPKXESc1n4lit47VNR/H9wPtkx55pNTRdFf3eLXE7d2yo7eMjxeA4jBVkI6HSY1tsuN8eDhFzeJPvqqBYFmIqUsREmtw9smS6DUZ6RyYGZiTQ36sTDjG0EghipfEAFhUcEOOUp3jed8gHJiLUIlEfhnBInSw9KnNDnenXLb+IY+rsQq+lNJgLwSC34dgekwTFcBfH8RlyIDjVtcUyP563j7i2tYBXGZTjn94VwOrwX1cuhe5zWskeEwecodufJuffS+fECMmDYsYCx90sdCKj3th1cgIB92j2DhdV2TAXMUyGxOqlql9rz8Rr21p5IVeJ5AQtwY/EMvTy4lc3qicjI5pkyANiDs+hASn/I5QlUYqMIFuN9wfs9pHTs80rJinnWnUgsTJ3kV/1YU1zq4j02sCR8q7XLSq4rPSZS16cRKi+FV1ehJzmU8QdFZn8/qvoNFa305gmZ9ufFY/MrBxPA62o4rwES7G4Gazr+6+bTPC+tSfzEBG1ET55a1ycy+XD2c0U4KhmJdb/iu0lyS/ITJ5lHuKtFSTp9EscNnsZZomEhHHJa4LeA5sw4qAGowQkxbR7azwq1ylkIbDwRbZo/aFHkij9sO9ikPc9jpiaqVpeLyQ1Rei3Yn2PDuTgfhCsRFmMFsU/0Ip8JoZPFwNgL/oNDCvOIHyp8iYn4uKj/gTHqvmzXDk/gg+w8rtvE2llNE+Q6zXTromdzhw3FVEMoeaibPq8I0csZQget/TLTEs3lo5ZelMRGAMgbdG7lkRYZcddz24wkT9F70/zjnEkGxDWWI655EH3tMRoRQQJvYcLL2JsVf31DgTEwh75awI8XE4lUF3fuG5g/EVSaOJWq2rhqdKcOWg3Y03VVORQhqd/Po9eBn1hWsdRa2uD3IQ7uPl+tnnv0CQvVNQZfFdyKKqJr8owcHb83fkg5TZOubEJ87JenZ3sdOM60h/LJzWCdcSWAreQsX054tsRpFf3tviqlNjf5bZQRoHOQou6SQHY8oF96a0gxyFZFCO5JRKtBReeZY3hLprGh19Rv6VW3fK1UQGQAo25x/53M9dRJtH25sVAAtnhJK0fS2/YcgzaWnRUGXaCc8NthyNHdcpXUaPP/92nerRBr2tYahBPnx3VXLDHGsXtVvNlbm4S0grdvH/o91yMBT/5rY2q8M0mwVenpS2Pvbdc+JwAt9A1Wl8KNL2KNXQ6Go4wC0rg1wR+Czp8QzC4iQNDDCmAPL2G0+T2QCrnjaiUvDF6sGz1O+CItN8MaILOOpOqzYgazJTPUGYHKO2X7/n2xkA8GP8SqSVQStvSCf17+mvPolaA4HulhqPGH06HIJTvkSrSZ0NQnfOb5nbJ+Vp9SK3TQhLslOO7P7NZJ0YqfOG6+7dPg4WkG/CrGE7/t9PRCOlfIr3hIIzh4BLy6bJwVz+NxkOtaMWswd60D7Vd60kImr1DmzylIR5qyzFIw0ZeSsMNR3tMtLd4tfCNv7m7UO3WAa0v9719Gk/25pOX+bcjSUn6klt94/v7G2TRaESTpjvlri4ggIlBV6M0oWN2sJ/41QTUZ+yd3FndEylAQri/FcElhGcMz5O X-OriginatorOrg: mbs-solutions.de X-MS-Exchange-CrossTenant-Network-Message-Id: c004be65-1033-4042-43e1-08dd39f36979 X-MS-Exchange-CrossTenant-AuthSource: FRYP281MB2522.DEUP281.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2025 08:12:56.7729 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 778c8b78-467e-4379-adca-743b91174c8a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A8eqIWNXffvAyUJa11QCBm8EDXvV+HqxmVAKIJ1gZGcb3eXaWmYB/cqpqD2uFIW1QreJWbm8HNm8zaKFqJaqZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BEYP281MB4519 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 21 Jan 2025 08:13:01 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/210071 Fixes [YOCTO #15579] This commit removes the LD_LIBRARY_PATH wrapper around `cargo`. Setting the LD_LIBRARY_PATH causes many problems. Some build scripts will not run because the build scripts execute binaries from the host system that are not compatible with the target libraries. Even a simple `cargo help build` can fail because it uses `less` internally, which should not be linked against the target libraries. There might be cases where the LD_LIBRARY_PATH is needed for some hosts, like the case described in 388e7cac9f90e79ce8c3c1683d8ee0f4df1bc907 but one can always set LD_LIBRARY_PATH manually if needed. A current working workaround without this commit would be always using `cargo.real` instead of `cargo`, which can lead to confusion. Signed-off-by: Jan Strater-Büddefeld Signed-off-by: Jan Strater-Büddefeld --- meta/recipes-devtools/rust/cargo_1.81.0.bb | 8 -------- 1 file changed, 8 deletions(-) diff --git a/meta/recipes-devtools/rust/cargo_1.81.0.bb b/meta/recipes-devtools/rust/cargo_1.81.0.bb index 123032cdf7..091ac3ae97 100644 --- a/meta/recipes-devtools/rust/cargo_1.81.0.bb +++ b/meta/recipes-devtools/rust/cargo_1.81.0.bb @@ -44,14 +44,6 @@ do_install () { install -m 755 "${B}/target/${CARGO_TARGET_SUBDIR}/cargo" "${D}${bindir}" } -do_install:append:class-nativesdk() { - # To quote the cargo docs, "Cargo also sets the dynamic library path when compiling - # and running binaries with commands like `cargo run` and `cargo test`". Sadly it - # sets to libdir but not base_libdir leading to symbol mismatches depending on the - # host OS. Fully set LD_LIBRARY_PATH to contain both to avoid this. - create_wrapper ${D}/${bindir}/cargo LD_LIBRARY_PATH=${libdir}:${base_libdir} -} - # Disabled due to incompatibility with libgit2 0.28.x (https://github.com/rust-lang/git2-rs/issues/458, https://bugs.gentoo.org/707746#c1) # as shipped by Yocto Dunfell. # According to https://github.com/rust-lang/git2-rs/issues/458#issuecomment-522567539, there are no compatibility guarantees between