diff mbox series

Also check that 'tools-debug' is not set in IMAGE_FEATURES to determine if gdbserver is missing.

Message ID 20241217101607.542503-2-tom.georgi@karlstorz.com
State New
Headers show
Series Also check that 'tools-debug' is not set in IMAGE_FEATURES to determine if gdbserver is missing. | expand

Commit Message

Georgi, Tom Dec. 17, 2024, 10:16 a.m. UTC
Hi all,
While using the relatively new devtool subcommand 'ide-sdk', I noticed that the gdbserver is listed as missing because it was not explicitly listed in IMAGE_INSTALL.
According to the documentation, it is also installed by the image feature 'tools-debug'.
Therefore, you should not only check whether 'gdbserver' is not in 'IMAGE_INSTALL', but also whether 'tools-debug' is not in IMAGE_FEATURES.

Best regards
Tom Georgi

Signed-off-by: Georgi, Tom <tom.georgi@karlstorz.com>
---
 scripts/lib/devtool/ide_sdk.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchtest@automation.yoctoproject.org Dec. 17, 2024, 10:31 a.m. UTC | #1
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/Also-check-that-tools-debug-is-not-set-in-IMAGE_FEATURES-to-determine-if-gdbserver-is-missing..patch

FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format)
FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less (currently 96 characters) (test_mbox.TestMbox.test_shortlog_length)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!
Randy MacLeod Dec. 19, 2024, 10:50 p.m. UTC | #2
Hi Georgi,

I think this is your first submission to oe-core - thanks for sending it in.

As Patchtest pointed out there are some problems we'd like you to fix up 
before resending.
I haven't been using this feature of devtool but your change looks 
sensible to me.

On 2024-12-17 5:31 a.m., Patchtest via lists.openembedded.org wrote:
> Thank you for your submission. Patchtest identified one
> or more issues with the patch. Please see the log below for
> more information:
>
> ---
> Testing patch /home/patchtest/share/mboxes/Also-check-that-tools-debug-is-not-set-in-IMAGE_FEATURES-to-determine-if-gdbserver-is-missing..patch
>
> FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format)
> FAIL: test shortlog length: Edit shortlog so that it is 90 characters or less (currently 96 characters) (test_mbox.TestMbox.test_shortlog_length)
Do those errors make sense Georgi?


For shortlog tips, look at:
❯ git log --oneline  -11 scripts/lib/devtool/
65950eb601 devtool: ide-sdk recommend DEBUG_BUILD
b886c26bf8 devtool: ide-sdk sort cmake preset
fc17808799 devtool: modify support debug-builds
d31a7718c1 scripts/devtool: use bb.util.listtasks instead of __BBTASKS
e6e548170a devtool: ide-sdk: fix help typo
02b52a2de3 devtool: drop useless variables
43f0c6beaa devtool: menuconfig remove useless code
2b799fdf26 devtool: drop S = WORKDIR workaround
94ff1be36a devtool: remove obsolete SRCTREECOVEREDTASKS handling
b0733c440e devtool: modify kernel adds append twice
4467aa0661 devtool/upgrade: rename RECIPE_UPDATE_EXTRA_TASKS -> 
RECIPE_UPGRADE_EXTRA_TASKS

and as Strunk and White said, omit needless words.  ;-)


Also for commits, we want to apply the change directly from email so 
please omit any greeting
unless you write a cover letter. Are you sending your patch with git 
send-email?
Have you seen our Contributor's Guide:
https://docs.yoctoproject.org/contributor-guide/index.html

Below is what happens if I apply your patch/email.
Hopefully by running git log and comparing your commit to others you can
get an idea of what is expected but don't get too hung up on it but 
rather just
CC me on your next version and I'll take a look.

Thanks,

../Randy


oe-core.git on master
❯ git am /tmp/devtool-fix.eml
Applying: Also check that 'tools-debug' is not set in IMAGE_FEATURES to 
determine if gdbserver is missing.

❯ git show
commit 43d08c7eb1297842fa62df55b66a13f109d6ec2d (HEAD -> master)
Author: Georgi, Tom via lists.openembedded.org 
<tom.georgi=karlstorz.com@lists.openembedded.org>
Date:   Tue Dec 17 05:16:08 2024

     Also check that 'tools-debug' is not set in IMAGE_FEATURES to 
determine if gdbserver is missing.

     Hi all,
     While using the relatively new devtool subcommand 'ide-sdk', I 
noticed that the gdbserver is listed as missing because it was not 
explicitly listed in IMAGE_INSTALL.
     According to the documentation, it is also installed by the image 
feature 'tools-debug'.
     Therefore, you should not only check whether 'gdbserver' is not in 
'IMAGE_INSTALL', but also whether 'tools-debug' is not in IMAGE_FEATURES.

     Best regards
     Tom Georgi

     Signed-off-by: Georgi, Tom <tom.georgi@karlstorz.com>

>
> PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
> PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
> PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
> PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
> PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
> PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
> PASS: test pylint (test_python_pylint.PyLint.test_pylint)
> PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
>
> SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
> SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
> SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
> SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
> SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
> SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
> SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
> SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
> SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
> SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
> SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
>
> ---
>
> Please address the issues identified and
> submit a new revision of the patch, or alternatively, reply to this
> email with an explanation of why the patch should be accepted. If you
> believe these results are due to an error in patchtest, please submit a
> bug athttps://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
> under 'Yocto Project Subprojects'). For more information on specific
> failures, see:https://wiki.yoctoproject.org/wiki/Patchtest. Thank
> you!
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#208830):https://lists.openembedded.org/g/openembedded-core/message/208830
> Mute This Topic:https://lists.openembedded.org/mt/110160631/3616765
> Group Owner:openembedded-core+owner@lists.openembedded.org
> Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/scripts/lib/devtool/ide_sdk.py b/scripts/lib/devtool/ide_sdk.py
index 2f6eddec2a..7b1cb67bbb 100755
--- a/scripts/lib/devtool/ide_sdk.py
+++ b/scripts/lib/devtool/ide_sdk.py
@@ -167,7 +167,7 @@  class RecipeImage:
             self.__rootfs_dbg = os.path.join(workdir, 'rootfs-dbg')
 
         self.gdbserver_missing = 'gdbserver' not in image_d.getVar(
-            'IMAGE_INSTALL')
+            'IMAGE_INSTALL') and 'tools-debug' not in image_d.getVar('IMAGE_FEATURES')
 
     @property
     def debug_support(self):