| Message ID | 20211120180507.1970003-2-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] core-image-ptest-all,core-image-ptest-fast: Depend on core-image class | expand |
On Sat, 2021-11-20 at 10:05 -0800, Khem Raj wrote: > base-image boots in degraded mode when using systems without display > system since there is no fb device detected and pslash service would > fail to start. Removing this image feature means that core-image-base is > complete for headless devices > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-core/images/core-image-base.bb | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/meta/recipes-core/images/core-image-base.bb b/meta/recipes-core/images/core-image-base.bb > index 75a08cfc92a..ced8de6c14f 100644 > --- a/meta/recipes-core/images/core-image-base.bb > +++ b/meta/recipes-core/images/core-image-base.bb > @@ -1,8 +1,6 @@ > SUMMARY = "A console-only image that fully supports the target device \ > hardware." > > -IMAGE_FEATURES += "splash" > - > LICENSE = "MIT" > > inherit core-image I think the way this was originally intended to work was to have a MACHINE_FEATURE which represented the possibility of a display, then the image could configure itself accordingly. Removing features from images to the lowest common denominator of any given hardware doesn't seem like the correct thing to do... Cheers, Richard
diff --git a/meta/recipes-core/images/core-image-base.bb b/meta/recipes-core/images/core-image-base.bb index 75a08cfc92a..ced8de6c14f 100644 --- a/meta/recipes-core/images/core-image-base.bb +++ b/meta/recipes-core/images/core-image-base.bb @@ -1,8 +1,6 @@ SUMMARY = "A console-only image that fully supports the target device \ hardware." -IMAGE_FEATURES += "splash" - LICENSE = "MIT" inherit core-image
base-image boots in degraded mode when using systems without display system since there is no fb device detected and pslash service would fail to start. Removing this image feature means that core-image-base is complete for headless devices Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-core/images/core-image-base.bb | 2 -- 1 file changed, 2 deletions(-)