From patchwork Sat Feb 15 12:42:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: auh@yoctoproject.org X-Patchwork-Id: 57373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 139C7C197BF for ; Sat, 15 Feb 2025 12:42:22 +0000 (UTC) Received: from a27-29.smtp-out.us-west-2.amazonses.com (a27-29.smtp-out.us-west-2.amazonses.com [54.240.27.29]) by mx.groups.io with SMTP id smtpd.web11.8056.1739623333145012007 for ; Sat, 15 Feb 2025 04:42:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@yoctoproject.org header.s=rnkzp2s7ci3kogmesvov2nwn7wcc2dgx header.b=UvXFwtNI; dkim=pass header.i=@amazonses.com header.s=7v7vs6w47njt4pimodk5mmttbegzsi6n header.b=c5GktG1z; spf=pass (domain: us-west-2.amazonses.com, ip: 54.240.27.29, mailfrom: 0101019509a17a01-987d94c5-6452-4e0f-9528-f90f020dfdda-000000@us-west-2.amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=rnkzp2s7ci3kogmesvov2nwn7wcc2dgx; d=yoctoproject.org; t=1739623332; h=Content-Type:MIME-Version:From:To:Cc:Subject:Message-Id:Date; bh=pZ+3dGO/fvll58MOqAF7fk9/5+3QLnw0S69b7xBO6w4=; b=UvXFwtNIp5sGzFpN6JzXMg/mgDPWIblrpmg4MHkE8iGycfLXcUnPxtKQEynFRlz0 fuqEzKCCMxMGfymuVXY5T11uAHhM7Q8OCUL2jZRB0kiiyWSOqJILpXsioYAJC48yOXH M/Rmww2QGqRdftUPhS0wy0wHwLDWE0Tlus7l3F8E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=7v7vs6w47njt4pimodk5mmttbegzsi6n; d=amazonses.com; t=1739623332; h=Content-Type:MIME-Version:From:To:Cc:Subject:Message-Id:Date:Feedback-ID; bh=pZ+3dGO/fvll58MOqAF7fk9/5+3QLnw0S69b7xBO6w4=; b=c5GktG1z4xsY9kCVrRqoffFRlEcJ9wXl05S7aCVG9a47V6R1GNqJY+DtEKXiB4t5 22r4gGSloxyfXMKKJg/Wq0M8VzpyL0vUzgRpbpfu4m+0UFc+FDYT05Y9gePpLlPfaE3 sbgkQMe8e1qp9F3864+o+Lp5xxI8JfnuPZvzne3Y= MIME-Version: 1.0 From: auh@yoctoproject.org To: Ross Burton Cc: openembedded-core@lists.openembedded.org Subject: [AUH] ofono: upgrading to 2.15 FAILED Message-ID: <0101019509a17a01-987d94c5-6452-4e0f-9528-f90f020dfdda-000000@us-west-2.amazonses.com> Date: Sat, 15 Feb 2025 12:42:12 +0000 Feedback-ID: ::1.us-west-2.9np3MYPs3fEaOBysGKSlUD4KtcmPijcmS9Az2Hwf7iQ=:AmazonSES X-SES-Outgoing: 2025.02.15-54.240.27.29 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sat, 15 Feb 2025 12:42:22 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/211408 Hello, this email is a notification from the Auto Upgrade Helper that the automatic attempt to upgrade the recipe(s) *ofono* to *2.15* has Failed(do_compile). Detailed error information: do_compile failed Next steps: - apply the patch: git am 0001-ofono-upgrade-2.14-2.15.patch - check the changes to upstream patches and summarize them in the commit message, - compile an image that contains the package - perform some basic sanity tests - amend the patch and sign it off: git commit -s --reset-author --amend - send it to the appropriate mailing list Alternatively, if you believe the recipe should not be upgraded at this time, you can fill RECIPE_NO_UPDATE_REASON in respective recipe file so that automatic upgrades would no longer be attempted. Please review the attached files for further information and build/update failures. Any problem please file a bug at https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler Regards, The Upgrade Helper -- >8 -- From 32b2a5f924a4bb73901642ec04fd2678cec9939a Mon Sep 17 00:00:00 2001 From: Upgrade Helper Date: Sat, 15 Feb 2025 06:27:02 +0000 Subject: [PATCH] ofono: upgrade 2.14 -> 2.15 --- .../ofono/ofono/CVE-2024-7539.patch | 88 ------------------- ...024-7540_CVE-2024-7541_CVE-2024-7542.patch | 52 ----------- .../ofono/ofono/rmnet.patch | 45 ---------- .../ofono/{ofono_2.14.bb => ofono_2.15.bb} | 12 +-- 4 files changed, 4 insertions(+), 193 deletions(-) delete mode 100644 meta/recipes-connectivity/ofono/ofono/CVE-2024-7539.patch delete mode 100644 meta/recipes-connectivity/ofono/ofono/CVE-2024-7540_CVE-2024-7541_CVE-2024-7542.patch delete mode 100644 meta/recipes-connectivity/ofono/ofono/rmnet.patch rename meta/recipes-connectivity/ofono/{ofono_2.14.bb => ofono_2.15.bb} (84%) diff --git a/meta/recipes-connectivity/ofono/ofono/CVE-2024-7539.patch b/meta/recipes-connectivity/ofono/ofono/CVE-2024-7539.patch deleted file mode 100644 index e41596959b..0000000000 --- a/meta/recipes-connectivity/ofono/ofono/CVE-2024-7539.patch +++ /dev/null @@ -1,88 +0,0 @@ -From 389e2344f86319265fb72ae590b470716e038fdc Mon Sep 17 00:00:00 2001 -From: Sicelo A. Mhlongo -Date: Tue, 17 Dec 2024 11:31:29 +0200 -Subject: [PATCH] ussd: ensure ussd content fits in buffers - -Fixes: CVE-2024-7539 - -CVE: CVE-2024-7539 -Upstream-Status: Backport [https://git.kernel.org/pub/scm/network/ofono/ofono.git/commit/?id=389e2344f86319265fb72ae590b470716e038fdc] - -Signed-off-by: Yogita Urade ---- - drivers/atmodem/ussd.c | 5 ++++- - drivers/huaweimodem/ussd.c | 5 ++++- - drivers/speedupmodem/ussd.c | 5 ++++- - 3 files changed, 12 insertions(+), 3 deletions(-) - -diff --git a/drivers/atmodem/ussd.c b/drivers/atmodem/ussd.c -index 32a9fe9..99da559 100644 ---- a/drivers/atmodem/ussd.c -+++ b/drivers/atmodem/ussd.c -@@ -93,7 +93,7 @@ static void cusd_parse(GAtResult *result, struct ofono_ussd *ussd) - const char *content; - int dcs; - enum sms_charset charset; -- unsigned char msg[160]; -+ unsigned char msg[160] = {0}; - const unsigned char *msg_ptr = NULL; - long msg_len; - -@@ -113,6 +113,9 @@ static void cusd_parse(GAtResult *result, struct ofono_ussd *ussd) - if (!g_at_result_iter_next_number(&iter, &dcs)) - dcs = 0; - -+ if (strlen(content) > sizeof(msg) * 2) -+ goto out; -+ - if (!cbs_dcs_decode(dcs, NULL, NULL, &charset, NULL, NULL, NULL)) { - ofono_error("Unsupported USSD data coding scheme (%02x)", dcs); - status = 4; /* Not supported */ -diff --git a/drivers/huaweimodem/ussd.c b/drivers/huaweimodem/ussd.c -index 5e1c907..3d165c8 100644 ---- a/drivers/huaweimodem/ussd.c -+++ b/drivers/huaweimodem/ussd.c -@@ -38,7 +38,7 @@ static void cusd_parse(GAtResult *result, struct ofono_ussd *ussd) - int status; - int dcs = 0; - const char *content; -- unsigned char msg[160]; -+ unsigned char msg[160] = {0}; - const unsigned char *msg_ptr = NULL; - long msg_len; - -@@ -55,6 +55,9 @@ static void cusd_parse(GAtResult *result, struct ofono_ussd *ussd) - - g_at_result_iter_next_number(&iter, &dcs); - -+ if (strlen(content) > sizeof(msg) * 2) -+ goto out; -+ - msg_ptr = decode_hex_own_buf(content, -1, &msg_len, 0, msg); - - out: -diff --git a/drivers/speedupmodem/ussd.c b/drivers/speedupmodem/ussd.c -index aafa4bc..a5efde0 100644 ---- a/drivers/speedupmodem/ussd.c -+++ b/drivers/speedupmodem/ussd.c -@@ -37,7 +37,7 @@ static void cusd_parse(GAtResult *result, struct ofono_ussd *ussd) - int status; - int dcs = 0; - const char *content; -- unsigned char msg[160]; -+ unsigned char msg[160] = {0}; - const unsigned char *msg_ptr = NULL; - long msg_len; - -@@ -54,6 +54,9 @@ static void cusd_parse(GAtResult *result, struct ofono_ussd *ussd) - - g_at_result_iter_next_number(&iter, &dcs); - -+ if (strlen(content) > sizeof(msg) * 2) -+ goto out; -+ - msg_ptr = decode_hex_own_buf(content, -1, &msg_len, 0, msg); - - out: --- -2.40.0 diff --git a/meta/recipes-connectivity/ofono/ofono/CVE-2024-7540_CVE-2024-7541_CVE-2024-7542.patch b/meta/recipes-connectivity/ofono/ofono/CVE-2024-7540_CVE-2024-7541_CVE-2024-7542.patch deleted file mode 100644 index fd97d4b51b..0000000000 --- a/meta/recipes-connectivity/ofono/ofono/CVE-2024-7540_CVE-2024-7541_CVE-2024-7542.patch +++ /dev/null @@ -1,52 +0,0 @@ -From 29ff6334b492504ace101be748b256e6953d2c2f Mon Sep 17 00:00:00 2001 -From: "Sicelo A. Mhlongo" -Date: Tue, 17 Dec 2024 11:31:28 +0200 -Subject: [PATCH] atmodem: sms: ensure buffer is initialized before use - -Fixes: CVE-2024-7540 -Fixes: CVE-2024-7541 -Fixes: CVE-2024-7542 - -CVE: CVE-2024-7540 -CVE: CVE-2024-7541 -CVE: CVE-2024-7542 -Upstream-Status: Backport [https://git.kernel.org/pub/scm/network/ofono/ofono.git/commit/?id=29ff6334b492504ace101be748b256e6953d2c2f] -Signed-off-by: Peter Marko ---- - drivers/atmodem/sms.c | 6 +++--- - 1 file changed, 3 insertions(+), 3 deletions(-) - -diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c -index d994856b..0668c631 100644 ---- a/drivers/atmodem/sms.c -+++ b/drivers/atmodem/sms.c -@@ -399,7 +399,7 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data) - struct sms_data *data = ofono_sms_get_data(sms); - GAtResultIter iter; - const char *hexpdu; -- unsigned char pdu[176]; -+ unsigned char pdu[176] = {0}; - long pdu_len; - int tpdu_len; - -@@ -466,7 +466,7 @@ static void at_cmgr_notify(GAtResult *result, gpointer user_data) - struct sms_data *data = ofono_sms_get_data(sms); - GAtResultIter iter; - const char *hexpdu; -- unsigned char pdu[176]; -+ unsigned char pdu[176] = {0}; - long pdu_len; - int tpdu_len; - -@@ -648,7 +648,7 @@ static void at_cmgl_notify(GAtResult *result, gpointer user_data) - struct sms_data *data = ofono_sms_get_data(sms); - GAtResultIter iter; - const char *hexpdu; -- unsigned char pdu[176]; -+ unsigned char pdu[176] = {0}; - long pdu_len; - int tpdu_len; - int index; --- -2.30.2 - diff --git a/meta/recipes-connectivity/ofono/ofono/rmnet.patch b/meta/recipes-connectivity/ofono/ofono/rmnet.patch deleted file mode 100644 index 11dfd5db18..0000000000 --- a/meta/recipes-connectivity/ofono/ofono/rmnet.patch +++ /dev/null @@ -1,45 +0,0 @@ -From git@z Thu Jan 1 00:00:00 1970 -Subject: [PATCH] rmnet: Handle toolchains with old kernel headers -From: Richard Purdie -Date: Thu, 19 Dec 2024 13:47:15 +0000 -Message-Id: -MIME-Version: 1.0 -Content-Type: text/plain; charset="utf-8" -Content-Transfer-Encoding: 7bit - -The RMNET_FLAGS_*GRESS_MAP_CKSUMV5 defines were added to the kernel in -5.14[1] and some toolchains use older headers, so add fallback defines -in case they are needed. - -[1] linux b6e5d27e32ef6089d316ce7e1ecaf595584d4b84 - -Upstream-Status: Submitted [https://lore.kernel.org/ofono/e2b6a94dd9a3789e31dafadfc70c53b565d1db04.camel@linuxfoundation.org/T/#u] -Signed-off-by: Ross Burton ---- - src/rmnet.c | 10 ++++++++++ - 1 file changed, 10 insertions(+) - -diff --git a/src/rmnet.c b/src/rmnet.c -index 42b03249..9a7f52fb 100644 ---- a/src/rmnet.c -+++ b/src/rmnet.c -@@ -27,6 +27,16 @@ - #define MAX_MUX_IDS 254U - #define DEFAULT_MTU 1400U - -+/* -+ * These were added in 5.14 so define them here if the toolchain's kernel headers are old. -+ */ -+#ifndef RMNET_FLAGS_INGRESS_MAP_CKSUMV5 -+#define RMNET_FLAGS_INGRESS_MAP_CKSUMV5 (1U << 4) -+#endif -+#ifndef RMNET_FLAGS_EGRESS_MAP_CKSUMV5 -+#define RMNET_FLAGS_EGRESS_MAP_CKSUMV5 (1U << 5) -+#endif -+ - struct rmnet_request { - uint32_t parent_ifindex; - rmnet_new_interfaces_func_t new_cb; --- -2.43.0 - diff --git a/meta/recipes-connectivity/ofono/ofono_2.14.bb b/meta/recipes-connectivity/ofono/ofono_2.15.bb similarity index 84% rename from meta/recipes-connectivity/ofono/ofono_2.14.bb rename to meta/recipes-connectivity/ofono/ofono_2.15.bb index 9a91afaa7b..40eeb3a086 100644 --- a/meta/recipes-connectivity/ofono/ofono_2.14.bb +++ b/meta/recipes-connectivity/ofono/ofono_2.15.bb @@ -7,14 +7,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \ file://src/ofono.h;beginline=1;endline=6;md5=13e42133935ceecfc9bcb547f256e277" DEPENDS = "dbus glib-2.0 udev mobile-broadband-provider-info ell" -SRC_URI = "\ - ${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \ - file://rmnet.patch \ - file://ofono \ - file://CVE-2024-7539.patch \ - file://CVE-2024-7540_CVE-2024-7541_CVE-2024-7542.patch \ -" -SRC_URI[sha256sum] = "983cbfd5e1e1a410ba7ad2db7f50fadc91e50b29f1ede40cdc73f941da7ba95f" +SRC_URI = "${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \ + file://ofono \ + " +SRC_URI[sha256sum] = "1af93ab72a70502452fe3d0297a6eaea13750cacae1fff3b643dd2245a6408ca" inherit autotools pkgconfig update-rc.d systemd gobject-introspection-data