From patchwork Sat Sep 28 07:00:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Weihmann X-Patchwork-Id: 49701 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A54CF6493 for ; Sat, 28 Sep 2024 07:00:32 +0000 (UTC) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (EUR02-AM0-obe.outbound.protection.outlook.com [40.92.49.98]) by mx.groups.io with SMTP id smtpd.web11.9180.1727506826095922038 for ; Sat, 28 Sep 2024 00:00:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=OmmdZRVJ; spf=pass (domain: outlook.com, ip: 40.92.49.98, mailfrom: kweihmann@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UJA/3sWtzSuiQ0R9DNTPNKScGH30rDy9g8PsYHs2bb+7X4jZObkobETQp8cxCG+DK933B998GRzv7TJF3XEa/FuwIgpeWi64FVg4prJhqqGaGS9dVUty+BZmIlL4/SundQzUmAEMOz8Wz6FGgtObPyl67hHDzHULH/WdxgCDDDjuxYagHLr52Myean0F6zv0Q3GryE5RxUcj0zWWIAu8o9B5vhaQ4yTmLTDPvji+MFe4QkUgAjfQxKma4Gqe85vombPWmLkaVuYRMJKyyvd5owqXJ8/dPJcoDDGUDJVjCbraxTAkeOnVZ9BN6bHxjW+hEDfb3rRqRoe6MCsNMRodNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4mMVEDXxYkgbmatEC3Jact7khixa+nQdVZO19Zh3dU=; b=Finz8uEDH/Zjt9arG3Pn+iVRbsw/WOAitRPguzSM6Cib/+/zv1kdZN4v7osrMAoH21g4KavdXR+zSbjlrcUbjEwxFV+NVNsXC/R6vh/AnStv8q3KHSQjpZJrlLgEz0hkO7p1ukGoHTohHselcQ2jtl+xf3w3bn23RbWi4GIrE83Hagg9RlOMYHRw5ivfDMplRj4e+cSPAGcwDzgsEVkr/j4aYqzOF6SeyKE/97kyHxGOJvVC9al0OIO7ZVkQYM0xq4o/UYpK8ZVhdvpHA92gLE9J76an1HoVjGR5RQT0LrsvOYdAzim9unKF8cXf0kIHqvVkz0BeRRbrPfNCEOSuzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4mMVEDXxYkgbmatEC3Jact7khixa+nQdVZO19Zh3dU=; b=OmmdZRVJ/UZFr41m09bRu79CZ2ZcVmY1O32B4YMBbQi/8eEe7wRSp1Mjhrdr7Kl9jrninHP2rpmjmRADhdXAYmml/C2ADdTU1d40PDGqcoTVOoNuUv/k2jeHcXvaVg52iuEpbXcgBN8UCGsc60S2rcbzjYP6s2Jff5bJ+QgM4iQIhMqKy6lMIo3Gu2XkSwHLw96jf9sbD27AUvBT7FbKSc3CpbNBVL00MEt3g0wp1gVvtRP/wJv9g2tvgJnjMXbtVOvJ92caIXCZrJC0q07nH045r6b1yD5LujfIRCP7DPQVqwxVxTWffO9zyc0Py6iqA4SpUbnQJl+niXICTPjI1A== Received: from GV1PR07MB9120.eurprd07.prod.outlook.com (2603:10a6:150:80::7) by DB9PR07MB7945.eurprd07.prod.outlook.com (2603:10a6:10:2a0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.24; Sat, 28 Sep 2024 07:00:24 +0000 Received: from GV1PR07MB9120.eurprd07.prod.outlook.com ([fe80::a630:7019:63e4:a48a]) by GV1PR07MB9120.eurprd07.prod.outlook.com ([fe80::a630:7019:63e4:a48a%6]) with mapi id 15.20.8005.020; Sat, 28 Sep 2024 07:00:24 +0000 Message-ID: Date: Sat, 28 Sep 2024 09:00:23 +0200 User-Agent: Mozilla Thunderbird From: Konrad Weihmann Subject: [PATCH v3 3/3] tests/parse: add coverage for old override syntax To: bitbake-devel@lists.openembedded.org Content-Language: en-US X-ClientProxiedBy: FR2P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::10) To GV1PR07MB9120.eurprd07.prod.outlook.com (2603:10a6:150:80::7) X-Microsoft-Original-Message-ID: <0228e795-3175-4fa3-9ea8-af2c3490f686@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1PR07MB9120:EE_|DB9PR07MB7945:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c6e4ab2-7236-4067-ea2a-08dcdf8b3959 X-Microsoft-Antispam: BCL:0;ARA:14566002|5072599009|8060799006|15080799006|7092599003|6090799003|19110799003|461199028|5062599005|440099028|3412199025; X-Microsoft-Antispam-Message-Info: uygXrfqlL8HLE1/av906B0b48kgf0Ek6wJRMn99ksFbhizVaUg1ucnkP/4i9a9ZaTTuB4ndMqjhBoavVin7H4kgmX5Xya7NUAwB+JppFPnwM4M/8/NewBvwx7hLm0/1gCfyVjU+t8aNtdtHa4y9+B6OIT9lYx7IhhoutxZa93Jj1XF7a3W7S7VPVTNupmxem8mB6zPDDZ8wHQVYZJgnYdWIm3qI4V3+ZI67G/PiZn3/e6Qpr/x11cMwj3IEOfvERARlQEEO/rWOony8iLBFdn5l5FmUo9ixJ4lxOBS90VMFp8hhsNTZ8zu8nqCfK/yBSELNt0DkAwr5/7P2JLHOu14LxOs+oc91BbrgU8H6TIfJApLqXVota0TGAl63XBzcaUsbCVtTv3RwHQEFDkskgQHOId+DSSsT5Z1lGXCy4rS7pgR97ZbRHVXVutJBYy2HjOGUaAE9nGX27aH/eDsi8vinnP+t2GCTcggcz9+q9BDJ0CEvEukDVtn9bPRQRJO/85l8TgCguEz51+14yLnFqsAqdkrDW+vib1Im98FgBOklT9KP5LAT38JwzAY8LsM3rNsFi484Wym7sMBO7ieEy+kVlYKlSZtOoXOu72pSA20XmIWzUVCjBhyGr+E1DtYHc1DVnU+37ceAP1J1udeUPWAqUPBvkHybFTSPFEdk6N9+rTzSQp2Y6W9+ECO+GSAX/oE3aDnMZzc2dD8lsI/qsUE4vU/9A2WX+zD6A9C8yljeq/nIVvbCXvWYyTiBT+njNbCh2pwu+YB1Qe+YelpdbqJrlPADZEDEb8i1YBkkrPRI= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?vFcx5FpHqnHnFDMmwCvJRpz+qQYF?= =?utf-8?q?XCJekY0fDpX+cfNly5vuhTImkkX068m6msjF1bcejE6hBHkZfm6mTg70p1jXo9QSi?= =?utf-8?q?qeicTYJ6pcocDmtPjn4pxfsOY5iaZiLRXhqVlfOCVTLKeUnzayoH4Grw9+7hau48h?= =?utf-8?q?i2VIAboZ2VYefsDsqunELqQO6kXGQtVL7k5YSto+TaJui96Mxkp0xPNS0Gmftiq00?= =?utf-8?q?42wVC+QHVDpnDjv/dfNIUhu/lQqEOd/1yRL8WFgLG7xd47BNswhZ35qwBLUavNMiK?= =?utf-8?q?pYrss2EYTD91+LPOL2hZc0NX6URnYhkSIYEktfkIsgAr3bWhh+GiSdvGJWyt786CG?= =?utf-8?q?sa2XNLAXRepZD7AUI49I/OQsmAYtoDiXx6wathMd6SpTwmM3A/GzfR2G3M8FBar3W?= =?utf-8?q?869wJey9VFkLgohw3ICl4555/RuXeYTw4xBVyekz5wh5XarlaYpiwCF0f28WMh4S0?= =?utf-8?q?Ddhy97wZaqNuLdOVgOgfjLpawimyJlhFD5mLt8YXsFXEc+rGjWRigcOBppZ9ie1qL?= =?utf-8?q?LgofV7xCqWfGZQJEg0QP2cmPDtlFFbn71N0OToOGBSGI5TTxGnXGDL3YM156E6osd?= =?utf-8?q?hKuN6chTp0I/kyV4L0GmyOzjnq8fB6cZd9o1HdLU6K06eiRwqdj3/K8PaT55aveL7?= =?utf-8?q?VDDa1g1LsdtTY8ndgOvdKvwhxM+D6YQaBE4Mg7kyc513XuuZE8PlSXPfeArNpgtuu?= =?utf-8?q?0nwoXsnwTe+FOqHzpjEDRZ15y9f9TpTBb4dBGvWzToE25DcPbpL2e6HusWAHvyhfo?= =?utf-8?q?M2GNHyXc0MeX3LA4bFh6ZqC3iE3fEfALaXtxSP007g/FQnTrjJ57aJDzuU/qQQLG9?= =?utf-8?q?JZ1IRVGtjHPq869/q7k3wrGCoZYZYiyn1m2d9yZZTAKpGDNZvZqT0o2Gm8v3eWVbV?= =?utf-8?q?CwrtD2DX6fKrDGHpSSWGO+7+dmGfVf5VOENNrdW3w39YCf35W1m8KmZA3BETTnKQL?= =?utf-8?q?0xtg8k1TowW7YTAg4Z+gTmPDfAUpk0SFzhSzJDh5lKF24biNyR7hljBZysvv/el/q?= =?utf-8?q?bMOsphoOiE5sHSfWrZ1BPKcraCO9omUXrasl33DiiPVE6+KSiIGtNEDMOBU4F9Gd1?= =?utf-8?q?mcvcOHy3ymzs8lltxPalu+05r3hefEp3Bz1wzuVGr0tU0oDmTJ5X2wxmxrxhdbTGM?= =?utf-8?q?mHIXpPIIYKfbCs8o/REXnY359MSNtqlGRMa7Y2W5U8VF6Q8/Qu+P7qpVxJJZMTn+N?= =?utf-8?q?H3YTAXeZ5P0rC6VrO/aLVtmvgstpyLK2aJPpXot4OlFaZx/+wfds5jNHNmzvNH3NP?= =?utf-8?q?9ztXHXdHTlizSKd8?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c6e4ab2-7236-4067-ea2a-08dcdf8b3959 X-MS-Exchange-CrossTenant-AuthSource: GV1PR07MB9120.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2024 07:00:23.6441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR07MB7945 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sat, 28 Sep 2024 07:00:32 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/16614 including previously unconvered tests for true failure cases of _prepend/_append/_remove. In addition add tests for not valid cases Signed-off-by: Konrad Weihmann --- lib/bb/tests/parse.py | 69 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/lib/bb/tests/parse.py b/lib/bb/tests/parse.py index 410679d5a..2da3a2a22 100644 --- a/lib/bb/tests/parse.py +++ b/lib/bb/tests/parse.py @@ -132,6 +132,75 @@ DESCRIPTION:${PN}-dev = "${DESCRIPTION} B" PN = "bc" """ + override_old_append = """ +EXTRA_OECONF_append = " c" +""" + + def test_parse_old_override_syntax_append(self): + f = self.parsehelper(self.override_old_append) + try: + bb.parse.handle(f.name, self.d)[''] + self.fail('Pattern should have raised bb.BBHandledException') + except bb.BBHandledException: + pass + + override_old_prepend = """ +EXTRA_OECONF_prepend = " c" +""" + + def test_parse_old_override_syntax_prepend(self): + f = self.parsehelper(self.override_old_prepend) + try: + bb.parse.handle(f.name, self.d)[''] + self.fail('Pattern should have raised bb.BBHandledException') + except bb.BBHandledException: + pass + + override_old_remove = """ +EXTRA_OECONF_remove = " c" +""" + + def test_parse_old_override_syntax_remove(self): + f = self.parsehelper(self.override_old_remove) + try: + bb.parse.handle(f.name, self.d)[''] + self.fail('Pattern should have raised bb.BBHandledException') + except bb.BBHandledException: + pass + + override_old_valid_append = """ +do_appendsomething () { + : +} +addtask do_appendsomething +""" + + def test_parse_old_override_syntax_no_warning_append(self): + f = self.parsehelper(self.override_old_valid_append) + bb.parse.handle(f.name, self.d)[''] + + override_old_valid_prepend = """ +do_prependsomething () { + : +} +addtask do_prependsomething +""" + + def test_parse_old_override_syntax_no_warning_prepend(self): + f = self.parsehelper(self.override_old_valid_prepend) + bb.parse.handle(f.name, self.d)[''] + + override_old_valid_remove = """ +do_removesomething () { + : +} +addtask do_removesomething +""" + + def test_parse_old_override_syntax_no_warning_remove(self): + f = self.parsehelper(self.override_old_valid_remove) + bb.parse.handle(f.name, self.d)[''] + def test_parse_combinations(self): f = self.parsehelper(self.overridetest3) d = bb.parse.handle(f.name, self.d)[''] -- 2.34.1