From patchwork Fri Sep 5 06:20:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Herbrechtsmeier X-Patchwork-Id: 69720 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC18CAC584 for ; Fri, 5 Sep 2025 06:21:24 +0000 (UTC) Received: from AM0PR02CU008.outbound.protection.outlook.com (AM0PR02CU008.outbound.protection.outlook.com [52.101.72.84]) by mx.groups.io with SMTP id smtpd.web10.14988.1757053280733913428 for ; Thu, 04 Sep 2025 23:21:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@weidmueller.com header.s=selector2 header.b=u4oF/xkW; spf=pass (domain: weidmueller.com, ip: 52.101.72.84, mailfrom: stefan.herbrechtsmeier-oss@weidmueller.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XUFF826d8snpvsjdYgt3iKs4wkB/rH5vkascer8ZIRNQsUAfDMa8ADlWgKheI2rnkS+g4EAvpCGKnCogQu1+Q6OCuPIYWTpuzaWwGr3+07+z7VDLEDY6QB25XyR9lk34ZoePqrmcy7K36cysORCd02Q0hWyxymC7Bpi5crZH3Bi04KYYQsv2HTxWvrJ+M27FNn8BVyuwO8KwBUDbwhPNPFzqVNnNhJWwvpXnxftpfrXC3sLV7H/7RiFZlxwSstKSCL0MBK2Q0d0cVbDsz59wyF2Xt1v/UzK8SZoiNixYTaI9+bwRSDtKlT9+AZde2t3BAU50njWVUPTebZywr9G50w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1aRqpEakDOUppHJG2UqbRXwPk+fOBmNyOOHP7eGaEOw=; b=MjM+UKYtki81tT744y5U1dkSxS5iucvXy5nHtxmLkEq7f/lgDk51MYeKvycpEXHOdrCGc/45jh6i6ltwDszN7zqaoe/LFLGegqVbJGp4qtGO2wZwNoFI0qgmSWJQDXdqvaXXJ8ClckjaRjWKx209GlRs5M6jL69SJkdEqvocHh0J5TPY1ewUlHWhv5Z+MIRPLoLvA3C6nGUsCYVpxSbj1y6YDZ0B/aFo3e/zTNjqGr26j55gReFY5KqvLjjsY6tPiOo++FeGc8QQGWlaeRC+PRPuiIuhVpo2eM7hrI8EuRz+56U4NVtgvrmrDvjbKv7n4UgqtFVNZUPjAxm1mRewTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1aRqpEakDOUppHJG2UqbRXwPk+fOBmNyOOHP7eGaEOw=; b=u4oF/xkW1isZ3RodU2SoPUuVDEBhPatYIZA95MKTZmkd5AF6uvTDDZYdp23QMNLAvRpBmOzPAvtQ2q7jodTx4CGIShQPVlwfD4XMZRCaJF5bPAAOEoq9b+hTFMJhA7R4+wDFCcRI5CldxHH9p4CJUHzhLhBlqcgrLDVoDZDDiO5aYV3nr0uGpcpJUEmtdnhiN5JhD7yrel51KDW/2oekfc0FSvTuNuVrspSozDfq3xN7VJCy4xhcUZbAKmTKQCXm8iHqkKi9g3PK2bjqtDPcwpzhqUJi/N/+rFA1kyy4PNFCIBrHCmNgndWRgN/w2H9IOm4mq3FeR9S4YkVQolvKeA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) by DU0PR08MB9632.eurprd08.prod.outlook.com (2603:10a6:10:447::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.17; Fri, 5 Sep 2025 06:21:15 +0000 Received: from DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25]) by DU0PR08MB8422.eurprd08.prod.outlook.com ([fe80::4ac7:a794:5e4b:fc25%4]) with mapi id 15.20.9094.017; Fri, 5 Sep 2025 06:21:15 +0000 From: Stefan Herbrechtsmeier To: bitbake-devel@lists.openembedded.org CC: Stefan Herbrechtsmeier Subject: [PATCH v2 13/15] fetch2: gitsm: remove useless need_update check Date: Fri, 5 Sep 2025 08:20:56 +0200 Message-ID: <20250905062058.2563806-14-stefan.herbrechtsmeier-oss@weidmueller.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> References: <20250905062058.2563806-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU0PR08MB8422.eurprd08.prod.outlook.com (2603:10a6:10:406::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR08MB8422:EE_|DU0PR08MB9632:EE_ X-MS-Office365-Filtering-Correlation-Id: ff25cc81-6e82-47e0-82f4-08ddec446ac6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: nL8Ich3LtVOyCcR8ilXWgL+Jw5qAY8Z+TpkjEHJL/2TUBAybtumBGxqkSb1SVKMiGXv4UI1bCV4tEhQQ+ohwx0n3Z1xlwwH7Jbi47XdGiOAjoguolbJxBoF42DrIhrF42NfGBLzrzMfpZ1rHGitGxKDh4eYy+vV4ATYl00LCeOdRvIdPSFBPvwHZd94lm8uHIkzH8guAdWYhgbIGPuvlrYCyFfdkE0/KfrYbYQ24jqO4T9Kfd/Pr19BfmWlgvdDk3NmCh6RparUJCwpACEgNVLhz+kXzWFri+KH9PGWbBdzPmLfxjrThh9UoQmw4RY0Kk27d7J81pzZRV0eIYLbEXk7DhZgwot58s2a7+6ncu0Xy78DGfHWq6f30pNU+h7dyxPLMdn87cTmo0OZYDGDTSt5CXACJNvD+nmzVKpMJWbPj1MGDmRQasWqIC36mEoVh8n0yPNb9BasRb++aVafvYX7puvNb4Lei4tv/GjBX4YKe1LUKyR4CFuTb1cuezT1r4Z4pvn+0M0DHgKi3neGf1Mq02733FyiMsERDs1Ddc89Xe8LlTjJPRVmiEFd+Ze5ZKnoUHsAJAR4JLpL0gUgul67vBl18kicKw3U5y4B/2Xo+Yznbof8FO1CGffuazvo9fCamRoGCxFlfdwxDiQcZSEmkWyUZRWZ27YjuczzEIYHvpgIgswpbZXSlQRD7iT5eQc1k/8BdRQ4QVBIHhaAm0g3WWfMlpMwRxcl1FVnxVQKc1UZC4X8rj1QtXuCkr2kwokI9TQjXkTRrrXihctM9tLbKWpjEkdHs6FshmzYyT2EaJFfTByW+uC/1FadEd1byflP7ZxlCT4zv1mDDM0nfNj9SlU5wbcEjt9DQtPpzR937ET0gB7t3P4VOZP/hI1NADHnEqJ/xYr7urHqsjUben/6YyJBxsid3pZX/eftliKwPHjuxJy7QfMQcsn4KG4ieFuK5DnlJR6Roz09RN2M+fwqZJIYWEeec3VicbLuPHzjyzhZ4No7xNE0Bt3OX62GS1g3xWZEKNdXmjIs+3NRWrboyrnlwHbllBbLrvIgfp4AQ1uq5Kmr3e3JDP5m8PN3B+m4u9ZJhPcpvnPJHBG23Lg0PLJQmBgO+HwKPzVMydeQ/kOjyu3sfis4T7gZ9HxYOzd6ojZ3pwJuY4k23aBE/sSLRWlKxaWsJY2ia6ZtqRlePepX6zzk+TC08xCz69s01HqSFUiy6DrJ2vTsRwXEQuAwvXNS44yHosjUk/W1iDVDJvDm9WfWIiVvkP0HTpv/JyoprEjpnFbO2AiRG6HAj5DbNHaboL6BZ5FinegHF3lEUG4SoQeMpYx+BwLRVgATMFOo6oB+dklslI/J+ZVDM+epbescjLkzBCzT3CKhE/8acdxkHn/cRRQfnciZQZvAW9eqi/64NMJFl+QBnCN6hGhIsPz/i3nNWiAKaSPG0/E4nTIbiuXWNprV9vrx3FAyklggr8vVP78LRg4RzGMI5yQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB8422.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5CO+IeUiDTnkMrcGlFiBt10GAvQ61MKiC1waWjppjSKDp201vKcnjGgyYWB7Nsi7ETh/pEGH8DgEp5W1XvuQbDgTUwSf48jmj7UN3LA5PAqdHwJJc/bo+Om0q7Ouw/ASinEw06jbe8w7T/aYr+11o6SbuLrhHhNx5FJjoWd7ijv6qe4lIWieFDVkxku7oCbrXsGglhFRfbwnmHean9ngQCVE54BLOAGrJgyx54PGU+/ecyfcw+FO9NCw4uN9NBdmamosH8AzuYNEW1aojjPys1arJRqLBKU/k435l/9vZigvMxEbv2xbT+UhGbKqmdgfm+0T36pBMAMbAozVkxydr545K2Ojwdm5FURmg6deLvhIgj6ZzYnrGuZre6tK+6phWmjVu/ZzEFe7IVueIF4LL4LDsPJgDOErGFWMGdaNuiCOw6rbDMjwpXnQrfCAqHNqxejTMI6SDFYoAxj/4qwqYmJX6eMjrIEX7gryNFZNgnNaJsD8Wr4ej2tdZHZ9xXXw4waipsEzyLb+t6bpvqPDTw1l+RtRPZmX1od0NFA1xHP9T80kfuR+CTrIcqtCgo6GR2XAnbUrOdxs+Y8vPOtj5366zCOhs+QZ57zUI8UgoDWVy6hD4l9fPvXvrGWi60Abc2MOOfyLh+9U5eV2SwM5hc96ys5/9ZKFvERzRpGFdgHzmfEEfLbdTQZpX6h9aSVFHGOrKSdRhEnDavdM/3qoUApVUEA+RrqKxC9E4qKYuRqiJXEcxWbWluntxQsazR+vkj5hbcdyu/27WayYmvW0C/avAgk+LIwkICK7PJbnMFUYwlIcEFXATpXWrpFUbTXfsoyql5DEQ2uaNWHpIu5QOdHA0cFGWEcJTCeUioNPtqdV/gQYyMVfEonVAOT7sgEKNSGS747qIklL3ozmvdyHRC6roA9CzHRGa0oiN40hr/qx8nBjCEhxRl2wBl92e2f9gygr/8BoA+DkmA/FaoTlsnQ+hrbD6+kNkcYojNXm2FziXsGIvQnoOFum6KG5e0N0BUO8Co+lkehWZ9FnliU3T0x0+ZYS21ru2mODRnuUcrcf4F69pcLhFZnxnMD7kDZuaIbKFjfTTJ6ZFZPppnnAW+QohPTc3BaT4aOTQxJd1QurbI9CuOXtCdPdLziTsfMwkyMFJmQME8tD70GudwxnA6cQ78z//88VDloc4j6E9uuFRd7VdcRUaPDiNGVib8Ew13NP4a8LSYP7tqrAycXheKWqc/MBRAPhbWQjNHsMIDjbNRcWJut/4lE6p7CdNAYA1yclU7Fot8M86SlLGvFMsotdOY57sOxIB0b1G5swVfEnhRP0mcWgN9McJL49DsAwrNbfwxTtVpVRJQNeAENglCByNYiqG48ZnNPfsAwTf6P+yKeh/LTEDqcoFQJ2XPBrspQEvkL83bNCpm/UycwYX+r2/t9QliaVvZhIUxVHYbe51SKwvILnyLpxHdQqziEd1ImZ3HPNXEQQvMsMqNasjppkO/savywOU5aNQrpPKEFSNvjwR2ArhEJg3knBI6WBp86JB0XsfGCV6ZktXf04TX3Z1UcdmDD35pT0JQPCwE6J44AUefG6r3hE8IOB8awp+MI5oXGEgzoYs5YT17mAaQ== X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff25cc81-6e82-47e0-82f4-08ddec446ac6 X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB8422.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2025 06:21:15.0948 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 58gj7uZOGwkAp12mvvN15yiabLNrRgeSd0zIXDpJfb0vl75Cupj90brbhHQVkHp/AIm3aN5ZrGBP5V3/qDVpaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9632 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 05 Sep 2025 06:21:24 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17970 From: Stefan Herbrechtsmeier The need_update check is useless to decide if the clone directory or temporary directory should be used to parse the submodules. If the git repository needs an update, it does not help to unpack the git archive and use it instead of the clone directory. Furthermore, it is useless to call the function of the class itself because it bypasses the check itself. Signed-off-by: Stefan Herbrechtsmeier --- (no changes since v1) lib/bb/fetch2/gitsm.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/bb/fetch2/gitsm.py b/lib/bb/fetch2/gitsm.py index 9afdc8370..31460b19e 100644 --- a/lib/bb/fetch2/gitsm.py +++ b/lib/bb/fetch2/gitsm.py @@ -143,13 +143,14 @@ class GitSM(Git): return submodules != [] - def call_process_submodules(self, ud, d, extra_check, subfunc): + def call_process_submodules(self, ud, d, subfunc): # If we're using a shallow mirror tarball it needs to be # unpacked temporarily so that we can examine the .gitmodules file # Unpack even when ud.clonedir is not available, # which may occur during a fast shallow clone - unpack = extra_check or not os.path.exists(ud.clonedir) - if ud.shallow and os.path.exists(ud.fullshallow) and unpack: + if os.path.exists(ud.clonedir): + self.process_submodules(ud, ud.clonedir, subfunc, d) + elif ud.shallow and os.path.exists(ud.fullshallow): tmpdir = tempfile.mkdtemp(dir=d.getVar("DL_DIR")) try: runfetchcmd("tar -xzf %s" % ud.fullshallow, d, workdir=tmpdir) @@ -157,7 +158,7 @@ class GitSM(Git): finally: shutil.rmtree(tmpdir) else: - self.process_submodules(ud, ud.clonedir, subfunc, d) + raise bb.fetch2.FetchError("Submodule source not available.") def need_update(self, ud, d): if Git.need_update(self, ud, d): @@ -174,7 +175,7 @@ class GitSM(Git): logger.error('gitsm: submodule update check failed: %s %s' % (type(e).__name__, str(e))) need_update_result = True - self.call_process_submodules(ud, d, True, need_update_submodule) + self.call_process_submodules(ud, d, need_update_submodule) if need_update_list: logger.debug('gitsm: Submodules requiring update: %s' % (' '.join(need_update_list))) @@ -195,7 +196,7 @@ class GitSM(Git): raise Git.download(self, ud, d) - self.call_process_submodules(ud, d, self.need_update(ud, d), download_submodule) + self.call_process_submodules(ud, d, download_submodule) def unpack(self, ud, destdir, d): fulldestdir = self.destdir(ud, destdir, d) @@ -247,7 +248,7 @@ class GitSM(Git): except Exception as e: logger.warning('gitsm: submodule clean failed: %s %s' % (type(e).__name__, str(e))) - self.call_process_submodules(ud, d, True, clean_submodule) + self.call_process_submodules(ud, d, clean_submodule) # Clean top git dir Git.clean(self, ud, d) @@ -260,6 +261,6 @@ class GitSM(Git): newfetch = Fetch([url], d, cache=False) urldata.extend(newfetch.expanded_urldata()) - self.call_process_submodules(ud, d, ud.method.need_update(ud, d), add_submodule) + self.call_process_submodules(ud, d, add_submodule) return urldata