trusted-firmware-a: Pin to use gcc for now

Message ID 20211208205809.3079680-1-raj.khem@gmail.com
State New
Headers show
Series trusted-firmware-a: Pin to use gcc for now | expand

Commit Message

Khem Raj Dec. 8, 2021, 8:58 p.m. UTC
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Ross Burton Dec. 9, 2021, 12:52 p.m. UTC | #1
What machine was this on?

Ross

On Wed, 8 Dec 2021 at 20:58, Khem Raj <raj.khem@gmail.com> wrote:
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  .../recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> index ec1bec9..dd8fd44 100644
> --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> @@ -10,3 +10,8 @@ SRC_URI_MBEDTLS = "git://github.com/ARMmbed/mbedtls.git;name=mbedtls;protocol=ht
>  SRCREV_mbedtls = "e483a77c85e1f9c1dd2eb1c5a8f552d2617fe400"
>
>  LIC_FILES_CHKSUM_MBEDTLS = "file://mbedtls/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> +
> +# code bloats with clang and results in error below now
> +# | aarch64-yoe-linux-musl-ld: region `PMUSRAM' overflowed by 3928 bytes
> +# this needs fixing until then use gcc
> +TOOLCHAIN = "gcc"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#2572): https://lists.yoctoproject.org/g/meta-arm/message/2572
> Mute This Topic: https://lists.yoctoproject.org/mt/87598328/1676615
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [ross@burtonini.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jon Mason Dec. 9, 2021, 1:08 p.m. UTC | #2
On Wed, Dec 08, 2021 at 12:58:09PM -0800, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  .../recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> index ec1bec9..dd8fd44 100644
> --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> @@ -10,3 +10,8 @@ SRC_URI_MBEDTLS = "git://github.com/ARMmbed/mbedtls.git;name=mbedtls;protocol=ht
>  SRCREV_mbedtls = "e483a77c85e1f9c1dd2eb1c5a8f552d2617fe400"
>  
>  LIC_FILES_CHKSUM_MBEDTLS = "file://mbedtls/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> +
> +# code bloats with clang and results in error below now
> +# | aarch64-yoe-linux-musl-ld: region `PMUSRAM' overflowed by 3928 bytes
> +# this needs fixing until then use gcc
> +TOOLCHAIN = "gcc"

Is the above error something that you will fix?  If so, can you open a
bug somewhere (like the yp bugzilla)?  If not, can you tell us how to
reproduce so that we can open a ticket in our internal jira?

I don't want this to be a forgotten workaround.

Thanks,
Jon

> -- 
> 2.34.1
> 
>
Jon Mason Dec. 9, 2021, 1:22 p.m. UTC | #3
On Wed, 8 Dec 2021 12:58:09 -0800, Khem Raj wrote:
> 


Applied, thanks!

[1/1] trusted-firmware-a: Pin to use gcc for now
      commit: ad030e5830803c308a6b035b8ba1f63d42d5dc2c

Best regards,
Khem Raj Dec. 9, 2021, 3:14 p.m. UTC | #4
On Thu, Dec 9, 2021 at 4:52 AM Ross Burton <ross@burtonini.com> wrote:

> What machine was this on?


Rockpi4b based on rk3399


>
> Ross
>
> On Wed, 8 Dec 2021 at 20:58, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  .../recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/
> trusted-firmware-a_2.6.bb b/meta-arm/recipes-bsp/trusted-firmware-a/
> trusted-firmware-a_2.6.bb
> > index ec1bec9..dd8fd44 100644
> > --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> > +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> > @@ -10,3 +10,8 @@ SRC_URI_MBEDTLS = "git://
> github.com/ARMmbed/mbedtls.git;name=mbedtls;protocol=ht
> >  SRCREV_mbedtls = "e483a77c85e1f9c1dd2eb1c5a8f552d2617fe400"
> >
> >  LIC_FILES_CHKSUM_MBEDTLS =
> "file://mbedtls/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> > +
> > +# code bloats with clang and results in error below now
> > +# | aarch64-yoe-linux-musl-ld: region `PMUSRAM' overflowed by 3928 bytes
> > +# this needs fixing until then use gcc
> > +TOOLCHAIN = "gcc"
> > --
> > 2.34.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#2572):
> https://lists.yoctoproject.org/g/meta-arm/message/2572
> > Mute This Topic: https://lists.yoctoproject.org/mt/87598328/1676615
> > Group Owner: meta-arm+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [
> ross@burtonini.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
Khem Raj Dec. 9, 2021, 3:15 p.m. UTC | #5
On Thu, Dec 9, 2021 at 5:08 AM Jon Mason <jdmason@kudzu.us> wrote:

> On Wed, Dec 08, 2021 at 12:58:09PM -0800, Khem Raj wrote:
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  .../recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/
> trusted-firmware-a_2.6.bb b/meta-arm/recipes-bsp/trusted-firmware-a/
> trusted-firmware-a_2.6.bb
> > index ec1bec9..dd8fd44 100644
> > --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> > +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
> > @@ -10,3 +10,8 @@ SRC_URI_MBEDTLS = "git://
> github.com/ARMmbed/mbedtls.git;name=mbedtls;protocol=ht
> >  SRCREV_mbedtls = "e483a77c85e1f9c1dd2eb1c5a8f552d2617fe400"
> >
> >  LIC_FILES_CHKSUM_MBEDTLS =
> "file://mbedtls/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> > +
> > +# code bloats with clang and results in error below now
> > +# | aarch64-yoe-linux-musl-ld: region `PMUSRAM' overflowed by 3928 bytes
> > +# this needs fixing until then use gcc
> > +TOOLCHAIN = "gcc"
>
> Is the above error something that you will fix?  If so, can you open a
> bug somewhere (like the yp bugzilla)?  If not, can you tell us how to
> reproduce so that we can open a ticket in our internal jira?
>

Reproduction is simple add meta-clang to your belayers.conf and set
TOOLCHAIN = “clang” in local.conf and unbolt this workaround

I might not be able to get it sooner

>
> I don't want this to be a forgotten workaround.
>
> Thanks,
> Jon
>
> > --
> > 2.34.1
> >
> >
>
Jon Mason Dec. 9, 2021, 5:06 p.m. UTC | #6
On Wed, 8 Dec 2021 12:58:09 -0800, Khem Raj wrote:
> 


Applied, thanks!

[1/1] trusted-firmware-a: Pin to use gcc for now
      commit: ad030e5830803c308a6b035b8ba1f63d42d5dc2c

Best regards,
Ross Burton Dec. 9, 2021, 5:56 p.m. UTC | #7
On Thu, 9 Dec 2021 at 15:16, Khem Raj <raj.khem@gmail.com> wrote:

> Reproduction is simple add meta-clang to your belayers.conf and set TOOLCHAIN = “clang” in local.conf and unbolt this workaround

We build TF-A with Clang for Juno, so this isn't a fundamental problem.

I'm tempted to say we should revert this and let meta-rockchip set
this with an override.

Ross
Khem Raj Dec. 9, 2021, 6:04 p.m. UTC | #8
On Thu, Dec 9, 2021 at 9:56 AM Ross Burton <ross@burtonini.com> wrote:
>
> On Thu, 9 Dec 2021 at 15:16, Khem Raj <raj.khem@gmail.com> wrote:
>
> > Reproduction is simple add meta-clang to your belayers.conf and set TOOLCHAIN = “clang” in local.conf and unbolt this workaround
>
> We build TF-A with Clang for Juno, so this isn't a fundamental problem.
>
> I'm tempted to say we should revert this and let meta-rockchip set
> this with an override.

Sounds good to me. If all machines in meta-arm are working fine with
clang. I can send a patch to meta-rockchip

>
> Ross

Patch

diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
index ec1bec9..dd8fd44 100644
--- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
+++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a_2.6.bb
@@ -10,3 +10,8 @@  SRC_URI_MBEDTLS = "git://github.com/ARMmbed/mbedtls.git;name=mbedtls;protocol=ht
 SRCREV_mbedtls = "e483a77c85e1f9c1dd2eb1c5a8f552d2617fe400"
 
 LIC_FILES_CHKSUM_MBEDTLS = "file://mbedtls/LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+# code bloats with clang and results in error below now
+# | aarch64-yoe-linux-musl-ld: region `PMUSRAM' overflowed by 3928 bytes
+# this needs fixing until then use gcc
+TOOLCHAIN = "gcc"