| Message ID | 20220603160300.28387-1-afd@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,dunfell/master] tiusdk-uenv: remove uEnv.txt for k3 | expand |
There's a typo in the subject - tiusdk-uenv On Fri, Jun 03, 2022 at 11:03:00AM -0500, Andrew Davis via lists.yoctoproject.org wrote: > This fixup should have been done in u-boot and not in a uEnv.txt > file. It is not correct for all K3 anymore either. Remove it. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../tisdk-uenv/tisdk-uenv/k3/uEnv.txt | 19 ------------------- > 1 file changed, 19 deletions(-) > delete mode 100644 meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt > > diff --git a/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt b/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt > deleted file mode 100644 > index 80ea34f5..00000000 > --- a/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt > +++ /dev/null > @@ -1,19 +0,0 @@ > -# This uEnv.txt file can contain additional environment settings that you > -# want to set in U-Boot at boot time. This can be simple variables such > -# as the serverip or custom variables. The format of this file is: > -# variable=value > -# NOTE: This file will be evaluated after the bootcmd is run and the > -# bootcmd must be set to load this file if it exists (this is the > -# default on all newer U-Boot images. This also means that some > -# variables such as bootdelay cannot be changed by this file since > -# it is not evaluated until the bootcmd is run. > - > -# The specific board is not able to be automatically detected. The below is a > -# workaround to set a sane default incase the user has not manually configured > -# a specific board. > -def_board_name="am65x" > - > -# Check if using default board_name when name_overlays is not set > -check_for_board=if test $name_overlays; then echo "Using board_name = $board_name"; else setenv board_name $def_board_name; fi > - > -uenvcmd=run check_for_board; run findfdt > -- > 2.36.1
On 6/3/22 4:01 PM, Denys Dmytriyenko wrote: > There's a typo in the subject - tiusdk-uenv > Looks like the same typo was in the patch that introduced this uEnv.txt file, copy/paste, v2 sent. Andrew > > On Fri, Jun 03, 2022 at 11:03:00AM -0500, Andrew Davis via lists.yoctoproject.org wrote: >> This fixup should have been done in u-boot and not in a uEnv.txt >> file. It is not correct for all K3 anymore either. Remove it. >> >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> .../tisdk-uenv/tisdk-uenv/k3/uEnv.txt | 19 ------------------- >> 1 file changed, 19 deletions(-) >> delete mode 100644 meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt >> >> diff --git a/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt b/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt >> deleted file mode 100644 >> index 80ea34f5..00000000 >> --- a/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt >> +++ /dev/null >> @@ -1,19 +0,0 @@ >> -# This uEnv.txt file can contain additional environment settings that you >> -# want to set in U-Boot at boot time. This can be simple variables such >> -# as the serverip or custom variables. The format of this file is: >> -# variable=value >> -# NOTE: This file will be evaluated after the bootcmd is run and the >> -# bootcmd must be set to load this file if it exists (this is the >> -# default on all newer U-Boot images. This also means that some >> -# variables such as bootdelay cannot be changed by this file since >> -# it is not evaluated until the bootcmd is run. >> - >> -# The specific board is not able to be automatically detected. The below is a >> -# workaround to set a sane default incase the user has not manually configured >> -# a specific board. >> -def_board_name="am65x" >> - >> -# Check if using default board_name when name_overlays is not set >> -check_for_board=if test $name_overlays; then echo "Using board_name = $board_name"; else setenv board_name $def_board_name; fi >> - >> -uenvcmd=run check_for_board; run findfdt >> -- >> 2.36.1
diff --git a/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt b/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt deleted file mode 100644 index 80ea34f5..00000000 --- a/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt +++ /dev/null @@ -1,19 +0,0 @@ -# This uEnv.txt file can contain additional environment settings that you -# want to set in U-Boot at boot time. This can be simple variables such -# as the serverip or custom variables. The format of this file is: -# variable=value -# NOTE: This file will be evaluated after the bootcmd is run and the -# bootcmd must be set to load this file if it exists (this is the -# default on all newer U-Boot images. This also means that some -# variables such as bootdelay cannot be changed by this file since -# it is not evaluated until the bootcmd is run. - -# The specific board is not able to be automatically detected. The below is a -# workaround to set a sane default incase the user has not manually configured -# a specific board. -def_board_name="am65x" - -# Check if using default board_name when name_overlays is not set -check_for_board=if test $name_overlays; then echo "Using board_name = $board_name"; else setenv board_name $def_board_name; fi - -uenvcmd=run check_for_board; run findfdt
This fixup should have been done in u-boot and not in a uEnv.txt file. It is not correct for all K3 anymore either. Remove it. Signed-off-by: Andrew Davis <afd@ti.com> --- .../tisdk-uenv/tisdk-uenv/k3/uEnv.txt | 19 ------------------- 1 file changed, 19 deletions(-) delete mode 100644 meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt